Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize feature const_copy_from_slice #138098

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

okaneco
Copy link
Contributor

@okaneco okaneco commented Mar 6, 2025

Stabilizes copy_from_slice method on [T]

FCP completed #131415 (comment)
Closes #131415

Stabilizes `copy_from_slice` method on `[T]`
@rustbot
Copy link
Collaborator

rustbot commented Mar 6, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 6, 2025
@tgross35
Copy link
Contributor

tgross35 commented Mar 6, 2025

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 6, 2025

📌 Commit d4c0c94 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2025
@RalfJung
Copy link
Member

RalfJung commented Mar 6, 2025

To avoid duplicate work, please always send a note in the tracking issue when you submit a stabilization PR for an FCP that you did not initiate.

@okaneco
Copy link
Contributor Author

okaneco commented Mar 6, 2025

Sorry about that.
I didn't know that there was an expectation that the person who started an FCP intended to stabilize it. I've seen accepted FCPs sit with no one initiating a PR.

In the future, if you could communicate that you intend to make the stabilization PR then hopefully that will be avoided.

I should have left a note directing to this PR on the tracking issue, and leaving a note should probably be part of the stabilization procedure regardless of who initiated FCP. Checking the linked issues/pulls at the bottom of the tracking issue UI for a stabilization PR is not as efficient as a standalone comment indicating that a PR has been made.

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2025
…mpiler-errors

Rollup of 17 pull requests

Successful merges:

 - rust-lang#137827 (Add timestamp to unstable feature usage metrics)
 - rust-lang#138041 (bootstrap and compiletest: Use `size_of_val` from the prelude instead of imported)
 - rust-lang#138046 (trim channel value in `get_closest_merge_commit`)
 - rust-lang#138053 (Increase the max. custom try jobs requested to `20`)
 - rust-lang#138061 (triagebot: add a `compiler_leads` ad-hoc group)
 - rust-lang#138064 (Remove - from xtensa targets cpu names)
 - rust-lang#138075 (Use final path segment for diagnostic)
 - rust-lang#138078 (Reduce the noise of bootstrap changelog warnings in --dry-run mode)
 - rust-lang#138081 (Move `yield` expressions behind their own feature gate)
 - rust-lang#138090 (`librustdoc`: flatten nested ifs)
 - rust-lang#138092 (Re-add `DynSend` and `DynSync` impls for `TyCtxt`)
 - rust-lang#138094 (a small borrowck cleanup)
 - rust-lang#138098 (Stabilize feature `const_copy_from_slice`)
 - rust-lang#138103 (Git ignore citool's target directory)
 - rust-lang#138105 (Fix broken link to Miri intrinsics in documentation)
 - rust-lang#138108 (Mention me (WaffleLapkin) when changes to `rustc_codegen_ssa` occur)
 - rust-lang#138117 ([llvm/PassWrapper] use `size_t` when building arg strings)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 33985ce into rust-lang:master Mar 7, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 7, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2025
Rollup merge of rust-lang#138098 - okaneco:stabilize_const_copy_from_slice, r=tgross35

Stabilize feature `const_copy_from_slice`

Stabilizes `copy_from_slice` method on `[T]`

FCP completed rust-lang#131415 (comment)
Closes rust-lang#131415
@RalfJung
Copy link
Member

RalfJung commented Mar 7, 2025 via email

@okaneco okaneco deleted the stabilize_const_copy_from_slice branch March 7, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue for const_copy_from_slice
5 participants