Subtree update of `rust-analyzer` #129054

lnicola · 2024-08-13T15:19:32Z

Selects a rust-toolchain declared RA based on its date. The earliest (oldest) RA wins and becomes the one that the workspace uses as a whole. In terms of precedence: nightly > stable-with-version > stable With stable-with-version, we invoke the RA with a `--version` arg and attempt to extract a date. Given the same date as a nightly, the nightly RA will win.

fix: Insert a tail `Ok(())` for expr block instead of wrapping with `Ok` Fixes rust-lang#17728 When type mismatch is `Result<(), E>, ()` or `Option<()>, ()` and target expr is a block expression, it is more reasonable to insert a wrapped unit - `Ok(())` or `Some(())` - as the tail expression of that block than wrapping the entire block with `Ok` or `Some`

feat: Use oldest rustup rust-analyzer when toolchain override is present Selects a rust-toolchain declared RA based on its date. The earliest (oldest) RA wins and becomes the one that the workspace uses as a whole. In terms of precedence: nightly > stable-with-version > stable With stable-with-version, we invoke the RA with a `--version` arg and attempt to extract a date. Given the same date as a nightly, the nightly RA will win. Fixes rust-lang#17663

… at once

internal: Remove AbsPathBuf::TryFrom impl that checks too many things at once rust-lang/rust-analyzer#16889 (comment)

fix: Insert a generic arg for `impl Trait` when lowering generic args Fixes rust-lang#17191 We are not inserting a generic arg when lowering generics like ```rust fn foo<T: B<impl A>(..) { ... } ``` but when we are lowering predicates we do; https://github.com/rust-lang/rust-analyzer/blob/aa00ddcf654a35ba0eafe17247cf189958d33182/crates/hir-ty/src/lower.rs#L1697-L1718 https://github.com/rust-lang/rust-analyzer/blob/aa00ddcf654a35ba0eafe17247cf189958d33182/crates/hir-ty/src/lower.rs#L310 and this mismatch causes index out of bound panic while substituting the predicates

feat: Load sysroot library via cargo metadata See rust-lang#128534, fixes rust-lang/rust-analyzer#7637 Requires a toolchain from 176e545 2024-08-04 or later to work.

internal: Newtype `ErasedFileAstId` It wrapping `la_arena::Idx` makes it quite annoying to use

feat: support inlay hint for more expr with label follow up rust-lang/rust-analyzer#17635

docs: add msvc note to manual Added note for Windows users to have the latest MSVC to minimize setup issues. Closes rust-lang#4870

Split out syntax-bridge into a separate crate This functionality is not really tied to mbe macros, so imo it has no place in that crate.

minor: sync from downstream

rustbot · 2024-08-13T15:19:37Z

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

lnicola · 2024-08-13T15:34:08Z

@bors r+ p=1 subtree update

bors · 2024-08-13T15:34:10Z

📌 Commit f96e296 has been approved by lnicola

It is now in the queue for this repository.

bors · 2024-08-13T19:06:55Z

⌛ Testing commit f96e296 with merge e46ddd3...

Subtree update of `rust-analyzer` r? `@ghost` CC `@ShoyuVanilla`

rust-log-analyzer · 2024-08-13T20:18:03Z

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2024-08-13T20:18:39Z

💔 Test failed - checks-actions

lnicola · 2024-08-14T05:00:39Z

@bors retry #128246

Subtree update of `rust-analyzer` r? `@ghost` CC `@ShoyuVanilla`

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#128828 (`-Znext-solver` caching) - rust-lang#128954 (Explicitly specify type parameter on FromResidual for Option and ControlFlow.) - rust-lang#129054 (Subtree update of `rust-analyzer`) - rust-lang#129059 (Record the correct target type when coercing fn items/closures to pointers) - rust-lang#129071 (Port `run-make/sysroot-crates-are-unstable` to rmake) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-08-14T11:46:27Z

⌛ Testing commit f96e296 with merge 0f442e2...

bors · 2024-08-14T14:12:40Z

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 0f442e2 to master...

rust-timer · 2024-08-14T15:28:06Z

Finished benchmarking commit (0f442e2): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-0.6%, -0.6%]	4
Improvements ✅ (secondary)	-0.4%	[-0.5%, -0.2%]	11
All ❌✅ (primary)	-0.6%	[-0.6%, -0.6%]	4

Max RSS (memory usage)

Results (primary -1.4%, secondary -0.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.4%	[-1.4%, -1.4%]	1
Improvements ✅ (secondary)	-0.9%	[-0.9%, -0.9%]	3
All ❌✅ (primary)	-1.4%	[-1.4%, -1.4%]	1

Cycles

Results (secondary 2.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.4%, 3.7%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 751.474s -> 751.854s (0.05%)
Artifact size: 341.45 MiB -> 341.43 MiB (-0.01%)

jieyouxu · 2024-08-15T04:00:42Z

#128246

I think this was meant to be #127883 since failed to remove cargo.exe, pinging back for more data points.

Mark-Simulacrum · 2024-08-19T23:32:34Z

Not a real perf improvement, delta from bimodality in these benchmarks.

huntc and others added 30 commits July 28, 2024 16:09

Checks date for any RA

786ef83

Further simplifications

6b4c0e0

Outdated comment removed

440b8be

Formatting

af4a59b

Corrected precedence position

8ca9034

fix: Insert a tail Ok(()) for expr block instead of wrapping with Ok

44f5392

feat: support inlay hint for more expr with label

cce9da3

internal: Remove AbsPathBuf::TryFrom impl that checks too many things…

5ac2ad4

… at once

Auto merge of rust-lang#17770 - Veykril:path-try-from, r=Veykril

6da26c1

internal: Remove AbsPathBuf::TryFrom impl that checks too many things at once rust-lang/rust-analyzer#16889 (comment)

internal: Load VFS config changes in parallel

07e6f9d

Wait with change processing until the vfs is done

2d8a494

test: add test case for inlay hint support for expr with label

a95ff26

fix: Insert a generic arg for impl Trait when lowering generic args

fbe7233

add msvc note to manual

b6b4e1a

feat: Load sysroot library via cargo metadata

ef7d2c5

Auto merge of rust-lang#17795 - Veykril:library-dep-loading, r=Veykril

d84b970

feat: Load sysroot library via cargo metadata See rust-lang#128534, fixes rust-lang/rust-analyzer#7637 Requires a toolchain from 176e545 2024-08-04 or later to work.

Simplify FileDelegate

2e7db9c

Split out syntax-bridge into a separate crate

90803b1

Newtype ErasedFileAstId

cdee65f

Auto merge of rust-lang#17794 - Veykril:source-db-simplify, r=Veykril

6825324

internal: Newtype `ErasedFileAstId` It wrapping `la_arena::Idx` makes it quite annoying to use

Simplify

f12aca9

Auto merge of rust-lang#17784 - Young-Flash:block_with_label, r=Veykril

78dea24

feat: support inlay hint for more expr with label follow up rust-lang/rust-analyzer#17635

Auto merge of rust-lang#17793 - jjoeldaniel:msvc-docs, r=Veykril

56fe166

docs: add msvc note to manual Added note for Windows users to have the latest MSVC to minimize setup issues. Closes rust-lang#4870

Auto merge of rust-lang#17799 - Veykril:syntax-bridge, r=Veykril

9d99d39

Split out syntax-bridge into a separate crate This functionality is not really tied to mbe macros, so imo it has no place in that crate.

feat: Implement diagnostic for await outside of async

3e809f8

minor: Fix metrics not running

92a07b8

Auto merge of rust-lang#17880 - lnicola:sync-from-rust, r=lnicola

f96e296

minor: sync from downstream

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 13, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 13, 2024

Auto merge of rust-lang#129054 - lnicola:sync-from-ra, r=lnicola

e46ddd3

Subtree update of `rust-analyzer` r? `@ghost` CC `@ShoyuVanilla`

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 13, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2024

matthiaskrgr mentioned this pull request Aug 14, 2024

Rollup of 5 pull requests #129082

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 14, 2024

Rollup merge of rust-lang#129054 - lnicola:sync-from-ra, r=lnicola

88b3169

Subtree update of `rust-analyzer` r? `@ghost` CC `@ShoyuVanilla`

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 14, 2024

bors merged commit 0f442e2 into rust-lang:master Aug 14, 2024
7 checks passed

rustbot added this to the 1.82.0 milestone Aug 14, 2024

lnicola deleted the sync-from-ra branch August 14, 2024 14:15

jieyouxu mentioned this pull request Aug 15, 2024

Tracking Issue for high failure rates on Windows MSVC CI with filesystem errors #127883

Open

jieyouxu added the CI-spurious-fail-msvc CI spurious failure: target env msvc label Oct 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Subtree update of `rust-analyzer` #129054

Subtree update of `rust-analyzer` #129054

lnicola commented Aug 13, 2024

rustbot commented Aug 13, 2024

lnicola commented Aug 13, 2024

bors commented Aug 13, 2024

bors commented Aug 13, 2024

rust-log-analyzer commented Aug 13, 2024

bors commented Aug 13, 2024

lnicola commented Aug 14, 2024

bors commented Aug 14, 2024

bors commented Aug 14, 2024

rust-timer commented Aug 14, 2024

jieyouxu commented Aug 15, 2024

Mark-Simulacrum commented Aug 19, 2024

Subtree update of rust-analyzer #129054

Subtree update of rust-analyzer #129054

Conversation

lnicola commented Aug 13, 2024

rustbot commented Aug 13, 2024

lnicola commented Aug 13, 2024

bors commented Aug 13, 2024

bors commented Aug 13, 2024

rust-log-analyzer commented Aug 13, 2024

bors commented Aug 13, 2024

lnicola commented Aug 14, 2024

bors commented Aug 14, 2024

bors commented Aug 14, 2024

rust-timer commented Aug 14, 2024

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

jieyouxu commented Aug 15, 2024

Mark-Simulacrum commented Aug 19, 2024

Subtree update of `rust-analyzer` #129054

Subtree update of `rust-analyzer` #129054