librustc: Forbid duplicate name bindings in the same parameter or type #17880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parameter list.
This breaks code like:
fn f(a: int, a: int) { ... }
fn g<T,T>(a: T) { ... }
Change this code to not use the same name for a parameter. For example:
fn f(a: int, b: int) { ... }
fn g<T,U>(a: T) { ... }
Code like this is *not* affected, since `_` is not an identifier:
fn f(_: int, _: int) { ... } // OK
Closes rust-lang#17568.
[breaking-change]
| for (index, type_parameter) in generics.ty_params.iter().enumerate() { | ||
| let ident = type_parameter.ident; | ||
| debug!("with_type_parameter_rib: {} {}", node_id, | ||
| type_parameter.id); | ||
|
|
||
| if seen_bindings.contains(&ident) { |
There was a problem hiding this comment.
This could just be if !seen_bindings.insert(ident) { ... }
bors
added a commit
that referenced
this pull request
Oct 9, 2014
…list, r=alexcrichton
parameter list.
This breaks code like:
fn f(a: int, a: int) { ... }
fn g<T,T>(a: T) { ... }
Change this code to not use the same name for a parameter. For example:
fn f(a: int, b: int) { ... }
fn g<T,U>(a: T) { ... }
Code like this is *not* affected, since `_` is not an identifier:
fn f(_: int, _: int) { ... } // OK
Closes #17568.
r? @alexcrichton
[breaking-change]
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Aug 13, 2024
minor: sync from downstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parameter list.
This breaks code like:
Change this code to not use the same name for a parameter. For example:
Code like this is not affected, since
_is not an identifier:Closes #17568.
r? @alexcrichton
[breaking-change]