internal: Enforce utf8 paths #16889
Merged
internal: Enforce utf8 paths #16889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
force-pushed
the
utf8-path
branch
6 times, most recently
from
c69d7f9
to
7a18ba7
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
bors
added a commit
that referenced
this pull request
Mar 20, 2024
fix: Fix project discovery not checking whether the `Cargo.toml` actually exists Got dropped in #16889, somehow r-a's codebase itself doesn't even run into this so I didn't see it when testing ...
matklad
reviewed
May 6, 2024
| Ok(AbsPathBuf(path_buf)) | ||
| } | ||
| } | ||
|
|
||
| impl TryFrom<PathBuf> for AbsPathBuf { |
There was a problem hiding this comment.
It feels like this impl should now be deleted? Not it is try for two orthogonal reasons:
- either the path is not valid utf-8
- or the path is not absolute
Better let the caller to explictily handle both of the possiblieties and do something like
AbsPathBuf::try_from(Utf8PathBuf::try_from(PathBuf)?)
This was referenced May 9, 2024
This was referenced May 28, 2024
This was referenced Jun 2, 2024
This was referenced Jun 11, 2024
bors
added a commit
that referenced
this pull request
Aug 2, 2024
internal: Remove AbsPathBuf::TryFrom impl that checks too many things at once #16889 (comment)
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Aug 13, 2024
internal: Remove AbsPathBuf::TryFrom impl that checks too many things at once rust-lang/rust-analyzer#16889 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cargo already requires this, and I highly doubt r-a works with non-utf8 paths generally either. This just makes dealing with paths a lot easier.