Turn remaining non-structural-const-in-pattern lints into hard errors

[RalfJung]

This completes the implementation of #120362 by turning our remaining future-compat lints into hard errors: indirect_structural_match and pointer_structural_match.

They have been future-compat lints for a while (indirect_structural_match for many years, pointer_structural_match since Rust 1.75 (released Dec 28, 2023)), and have shown up in dependency breakage reports since Rust 1.78 (just released on May 2, 2024). I don't expect a lot of code will still depend on them, but we will of course do a crater run.

A lot of cleanup is now possible in const_to_pat, but that is deferred to a later PR.

Fixes #70861

[rustbot]

r? @pnkfelix

rustbot has assigned @pnkfelix.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

Some changes occurred in match checking

cc @Nadrieril

[RalfJung]

@bors try

[bors]

⌛ Trying commit cbd682b with merge 8348c7b...

[bors]

☀️ Try build successful - checks-actions
Build commit: 8348c7b (8348c7b12e5a2c6b3311d00662c71e8ceda0a1c8)

[RalfJung]

@craterbot check

[craterbot]

👌 Experiment pr-124661 created and queued.
🤖 Automatically detected try build 8348c7b
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🚧 Experiment pr-124661 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🎉 Experiment pr-124661 is completed!
📊 23 regressed and 2 fixed (445552 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[RalfJung]

Many of these are caused by -D renamed-and-removed-lints. (Not sure where that flag comes from, does crater set it? That wouldn't make sense...)

On crates.io we have two true regression:

• ctti (<1k total downloads, author notified)
• cambridge-asm (~13k total downloads, author notified)

The github failures are either false positives, duplicates of one of these crates, or advent of code repos.

I think we can go ahead and land this. (Remember, if it lands now crate authors still have until July 25th before this hits stable.) Nominating for t-lang.

[pnkfelix]

Oh noes, it doesn't sequence the commands to remove the label before firing off the rfcbot command!

@rfcbot cancel

[rfcbot]

@pnkfelix proposal cancelled.

[pnkfelix]

@rfcbot fcp merge

(I'm just preemptively firing up a T-lang FCP to approve this change.)

[rfcbot]

Team member @pnkfelix has proposed to merge this. The next step is review by the rest of the tagged team members:

• @joshtriplett
• @nikomatsakis
• @pnkfelix
• @scottmcm
• @tmandry

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

[nikomatsakis]

@rfcbot reviewed

…

On Tue, May 14, 2024, at 1:54 PM, Rust RFC bot wrote: Team member @pnkfelix <https://github.com/pnkfelix> has proposed to merge this. The next step is review by the rest of the tagged team members: • @joshtriplett <https://github.com/joshtriplett> • @nikomatsakis <https://github.com/nikomatsakis> • @pnkfelix <https://github.com/pnkfelix> • @scottmcm <https://github.com/scottmcm> • @tmandry <https://github.com/tmandry> No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! cc @rust-lang/lang-advisors <https://github.com/orgs/rust-lang/teams/lang-advisors>: FCP proposed for lang, please feel free to register concerns. See this document <https://github.com/rust-lang/rfcbot-rs/blob/master/README.md> for info about what commands tagged team members can give me. — Reply to this email directly, view it on GitHub <#124661 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABF4ZXIYZS3B6MPDUODVBLZCJFUZAVCNFSM6AAAAABHFSCSYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJQHAYDIMBQGE>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[rfcbot]

🔔 This is now entering its final comment period, as per the review above. 🔔

[traviscross]

@rustbot labels -I-lang-nominated

We discussed this in the triage meeting today, and it's now in FCP.

[rfcbot]

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

[RalfJung]

@pnkfelix wrote

The code itself seems fine

@bors r=pnkfelix

[bors]

📌 Commit cbd682b has been approved by pnkfelix

It is now in the queue for this repository.

[bors]

⌛ Testing commit cbd682b with merge 5fe5543...

[bors]

☀️ Test successful - checks-actions
Approved by: pnkfelix
Pushing 5fe5543 to master...

[rust-timer]

Finished benchmarking commit (5fe5543): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.2%	[0.3%, 2.1%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -0.2%, secondary 0.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.9%, 1.9%]	1
Regressions ❌ (secondary)	4.2%	[4.2%, 4.2%]	1
Improvements ✅ (primary)	-1.3%	[-2.0%, -0.5%]	2
Improvements ✅ (secondary)	-3.6%	[-3.6%, -3.6%]	1
All ❌✅ (primary)	-0.2%	[-2.0%, 1.9%]	3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.39s -> 670.355s (-0.15%)
Artifact size: 315.55 MiB -> 315.71 MiB (0.05%)