Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pointer_structural_match lint will become a hard error soon #3

Open
RalfJung opened this issue May 3, 2024 · 0 comments
Open

pointer_structural_match lint will become a hard error soon #3

RalfJung opened this issue May 3, 2024 · 0 comments

Comments

@RalfJung
Copy link

RalfJung commented May 3, 2024

This crate triggers the pointer_structural_match lint:

f => Ok(Self::Parent($parent::from_func_ptr(f)?)),

Matching against function pointers is not reliable and will become a hard error once rust-lang/rust#124661 lands, as was decided in rust-lang/rfcs#3535. I recommend comparing with == instead (though that will be just as unreliable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant