-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide prebuilt std for gnullvm targets #121712
Provide prebuilt std for gnullvm targets #121712
Conversation
I'm not sure who is best to review this. r? infra-ci |
Why is this not updating the platform support docs to indicate this is now a tier 2 target (without host tools)? I'm generally fine with landing this presuming the relevant approvals have been obtained. Building just std doesn't take that long so I'm not too worried about added CI time. |
280a431
to
14b18e9
Compare
Fixed. @rustbot ready |
@bors r+ |
@bors r- |
14b18e9
to
2eba855
Compare
Sorry, I was under impression this table is generated from other files. Also found out the machine where I had built Dockerfile had not fully rebased branch and with current master this fails to build. @rustbot blocked |
This comment has been minimized.
This comment has been minimized.
A fix for this has now been merged, and it looks like they even released a new version of the compiler-builtins crate (0.1.109). There's a PR to update compiler_builtins in #123719 |
Yeah, I already saw #123719 and I'm waiting for it to merge. |
46500e9
to
c395176
Compare
Some changes occurred in src/doc/rustc/src/platform-support cc @Nilstrieb |
c395176
to
cd4c0da
Compare
Rebased, updated the toolchain and tested locally using @rustbot ready |
@bors r+ rollup=never |
☀️ Test successful - checks-actions |
Finished benchmarking commit (8cf135e): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 672.07s -> 672.886s (0.12%) |
…ifest, r=Mark-Simulacrum Add gnullvm targets to manifest Fixes an oversight from rust-lang#121712
…ifest, r=Mark-Simulacrum Add gnullvm targets to manifest Fixes an oversight from rust-lang#121712
…ifest, r=Mark-Simulacrum Add gnullvm targets to manifest Fixes an oversight from rust-lang#121712
Rollup merge of rust-lang#124229 - mati865:add-gnullvm-targets-to-manifest, r=Mark-Simulacrum Add gnullvm targets to manifest Fixes an oversight from rust-lang#121712
Revival of #114346 which waiting on MCP that was accepted recently: rust-lang/compiler-team#710 (comment)