test: relax assertions of panic message (again) #12500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ehuss (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
nyurik
reviewed
Aug 14, 2023
| .with_stdout_contains("[..]assertion failed[..]") | ||
| .with_stdout_contains("[..]left: `\"hello\"`[..]") | ||
| .with_stdout_contains("[..]right: `\"nope\"`[..]") | ||
| .with_stdout_contains("[..]assertion [..]failed[..]") |
There was a problem hiding this comment.
thanks @weihanglo! Does [..] match .* or .+ (in regex terms)?
There was a problem hiding this comment.
Yes, similar to .* for a line. Please see https://doc.rust-lang.org/nightly/nightly-rustc/cargo_test_support/compare/index.html.
I am doing this because it need to match both stable and nightly formats to pass Cargo's CI 🥲
|
@bors r+ |
bors
added
S-waiting-on-bors
|
I'd be tempted to say RenovateBot should update our nightly every night but that would get tedious to merge and would flood our commit history |
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 14, 2023
Update cargo 6 commits in 7e9de3f4ec3708f500bec142317895b96131e47c..7c3904d6c3ed54e8a413023519b55a536ad44d5b 2023-08-13 00:47:32 +0000 to 2023-08-14 20:11:43 +0000 - fix(lints): Doctest extraction should respect `[lints]` (rust-lang/cargo#12501) - test: relax assertions of panic message (again) (rust-lang/cargo#12500) - doc(unstable): `cargo test` does not provide `--keep-going` (rust-lang/cargo#12492) - fix(log): enable ansi color only in terminal (rust-lang/cargo#12488) - Update cargo-yank.md (rust-lang/cargo#12490) - test: bypass `rustc --test` impl details for `-Zfuture-incompat-test` (rust-lang/cargo#12491) r? `@ghost`
bors
added a commit
that referenced
this pull request
Aug 26, 2023
[stable-1.72.0] add missing `windows-sys` features back Stable backports: - <#12563> In order to make CI pass, the following PRs are also cherry-picked: - b4a26b0 from #12475 - c508cb6 from #12538 - 43c253e from #12351 - 689defd from #12500 --- Fixes <#12562> This won't affect Rust releases, i.e. no 1.72.1 will happen. We do this only for release `cargo` crate.
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Apr 7, 2024
Update cargo 6 commits in 7e9de3f4ec3708f500bec142317895b96131e47c..7c3904d6c3ed54e8a413023519b55a536ad44d5b 2023-08-13 00:47:32 +0000 to 2023-08-14 20:11:43 +0000 - fix(lints): Doctest extraction should respect `[lints]` (rust-lang/cargo#12501) - test: relax assertions of panic message (again) (rust-lang/cargo#12500) - doc(unstable): `cargo test` does not provide `--keep-going` (rust-lang/cargo#12492) - fix(log): enable ansi color only in terminal (rust-lang/cargo#12488) - Update cargo-yank.md (rust-lang/cargo#12490) - test: bypass `rustc --test` impl details for `-Zfuture-incompat-test` (rust-lang/cargo#12491) r? `@ghost`
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
Update cargo 6 commits in 7e9de3f4ec3708f500bec142317895b96131e47c..7c3904d6c3ed54e8a413023519b55a536ad44d5b 2023-08-13 00:47:32 +0000 to 2023-08-14 20:11:43 +0000 - fix(lints): Doctest extraction should respect `[lints]` (rust-lang/cargo#12501) - test: relax assertions of panic message (again) (rust-lang/cargo#12500) - doc(unstable): `cargo test` does not provide `--keep-going` (rust-lang/cargo#12492) - fix(log): enable ansi color only in terminal (rust-lang/cargo#12488) - Update cargo-yank.md (rust-lang/cargo#12490) - test: bypass `rustc --test` impl details for `-Zfuture-incompat-test` (rust-lang/cargo#12491) r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Fixes test failure in rust-lang/rust#111071
Similar PR in the past: #12413
How to test
Built std from rust-lang/rust#111071 and test against Cargo's test suite in this PR.