Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: bypass rustc --test impl details for -Zfuture-incompat-test #12491

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

weihanglo
Copy link
Member

@weihanglo weihanglo commented Aug 14, 2023

Switch to an empty lib.rs from main.rs.

See rust-lang/rust#114804 (comment)

Closes rust-lang/rust#114804

@rustbot
Copy link
Collaborator

rustbot commented Aug 14, 2023

r? @epage

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 14, 2023
@ehuss
Copy link
Contributor

ehuss commented Aug 14, 2023

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 14, 2023

📌 Commit b567a67 has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2023
@bors
Copy link
Collaborator

bors commented Aug 14, 2023

⌛ Testing commit b567a67 with merge 18f2b46...

@bors
Copy link
Collaborator

bors commented Aug 14, 2023

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 18f2b46 to master...

@bors bors merged commit 18f2b46 into rust-lang:master Aug 14, 2023
19 checks passed
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 14, 2023
Update cargo

6 commits in 7e9de3f4ec3708f500bec142317895b96131e47c..7c3904d6c3ed54e8a413023519b55a536ad44d5b
2023-08-13 00:47:32 +0000 to 2023-08-14 20:11:43 +0000
- fix(lints): Doctest extraction should respect `[lints]` (rust-lang/cargo#12501)
- test: relax assertions of panic message (again) (rust-lang/cargo#12500)
- doc(unstable): `cargo test` does not provide `--keep-going` (rust-lang/cargo#12492)
- fix(log): enable ansi color only in terminal (rust-lang/cargo#12488)
- Update cargo-yank.md (rust-lang/cargo#12490)
- test: bypass `rustc --test` impl details for `-Zfuture-incompat-test` (rust-lang/cargo#12491)

r? `@ghost`
bors added a commit that referenced this pull request Aug 15, 2023
[beta-1.72.0] bump cargo-util to 0.2.5

#11442 changed `cargo-util` at the last minute but we failed to bump the version.

And due to #12347, version bump check didn't work well at that time.

In order to make CI pass, the following PRs are also cherry-picked:

* #12450
* #12491
@weihanglo weihanglo deleted the fix-future-incompat branch August 16, 2023 18:56
@ehuss ehuss added this to the 1.73.0 milestone Aug 22, 2023
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Apr 7, 2024
Update cargo

6 commits in 7e9de3f4ec3708f500bec142317895b96131e47c..7c3904d6c3ed54e8a413023519b55a536ad44d5b
2023-08-13 00:47:32 +0000 to 2023-08-14 20:11:43 +0000
- fix(lints): Doctest extraction should respect `[lints]` (rust-lang/cargo#12501)
- test: relax assertions of panic message (again) (rust-lang/cargo#12500)
- doc(unstable): `cargo test` does not provide `--keep-going` (rust-lang/cargo#12492)
- fix(log): enable ansi color only in terminal (rust-lang/cargo#12488)
- Update cargo-yank.md (rust-lang/cargo#12490)
- test: bypass `rustc --test` impl details for `-Zfuture-incompat-test` (rust-lang/cargo#12491)

r? `@ghost`
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 27, 2024
Update cargo

6 commits in 7e9de3f4ec3708f500bec142317895b96131e47c..7c3904d6c3ed54e8a413023519b55a536ad44d5b
2023-08-13 00:47:32 +0000 to 2023-08-14 20:11:43 +0000
- fix(lints): Doctest extraction should respect `[lints]` (rust-lang/cargo#12501)
- test: relax assertions of panic message (again) (rust-lang/cargo#12500)
- doc(unstable): `cargo test` does not provide `--keep-going` (rust-lang/cargo#12492)
- fix(log): enable ansi color only in terminal (rust-lang/cargo#12488)
- Update cargo-yank.md (rust-lang/cargo#12490)
- test: bypass `rustc --test` impl details for `-Zfuture-incompat-test` (rust-lang/cargo#12491)

r? `@ghost`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nightly regression?: dead_code detection with -Zfuture-incompat-test
6 participants