Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(unstable): cargo test does not provide --keep-going #12492

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

weihanglo
Copy link
Member

#12478 removed --keep-going from cargo test but forgot to update relevant doc.

@rustbot
Copy link
Collaborator

rustbot commented Aug 14, 2023

r? @epage

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2023
@epage
Copy link
Contributor

epage commented Aug 14, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 14, 2023

📌 Commit b45ffa9 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2023
@bors
Copy link
Collaborator

bors commented Aug 14, 2023

⌛ Testing commit b45ffa9 with merge 1993a29...

bors added a commit that referenced this pull request Aug 14, 2023
doc(unstable): `cargo test` does not provide `--keep-going`
@bors
Copy link
Collaborator

bors commented Aug 14, 2023

☀️ Test successful - checks-actions
Approved by: epage
Pushing 1993a29 to master...

@bors
Copy link
Collaborator

bors commented Aug 14, 2023

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

@weihanglo
Copy link
Member Author

@bors retry

@weihanglo
Copy link
Member Author

@bors r-

@bors bors added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 14, 2023
@weihanglo
Copy link
Member Author

@bors r=epage

@bors
Copy link
Collaborator

bors commented Aug 14, 2023

📌 Commit b45ffa9 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. labels Aug 14, 2023
@bors
Copy link
Collaborator

bors commented Aug 14, 2023

⌛ Testing commit b45ffa9 with merge 3b4dd4b...

@bors
Copy link
Collaborator

bors commented Aug 14, 2023

☀️ Test successful - checks-actions
Approved by: epage
Pushing 3b4dd4b to master...

@bors bors merged commit 3b4dd4b into rust-lang:master Aug 14, 2023
12 of 19 checks passed
@weihanglo weihanglo deleted the keep-going-doc branch August 14, 2023 18:53
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 14, 2023
Update cargo

6 commits in 7e9de3f4ec3708f500bec142317895b96131e47c..7c3904d6c3ed54e8a413023519b55a536ad44d5b
2023-08-13 00:47:32 +0000 to 2023-08-14 20:11:43 +0000
- fix(lints): Doctest extraction should respect `[lints]` (rust-lang/cargo#12501)
- test: relax assertions of panic message (again) (rust-lang/cargo#12500)
- doc(unstable): `cargo test` does not provide `--keep-going` (rust-lang/cargo#12492)
- fix(log): enable ansi color only in terminal (rust-lang/cargo#12488)
- Update cargo-yank.md (rust-lang/cargo#12490)
- test: bypass `rustc --test` impl details for `-Zfuture-incompat-test` (rust-lang/cargo#12491)

r? `@ghost`
@ehuss ehuss added this to the 1.73.0 milestone Aug 22, 2023
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Apr 7, 2024
Update cargo

6 commits in 7e9de3f4ec3708f500bec142317895b96131e47c..7c3904d6c3ed54e8a413023519b55a536ad44d5b
2023-08-13 00:47:32 +0000 to 2023-08-14 20:11:43 +0000
- fix(lints): Doctest extraction should respect `[lints]` (rust-lang/cargo#12501)
- test: relax assertions of panic message (again) (rust-lang/cargo#12500)
- doc(unstable): `cargo test` does not provide `--keep-going` (rust-lang/cargo#12492)
- fix(log): enable ansi color only in terminal (rust-lang/cargo#12488)
- Update cargo-yank.md (rust-lang/cargo#12490)
- test: bypass `rustc --test` impl details for `-Zfuture-incompat-test` (rust-lang/cargo#12491)

r? `@ghost`
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 27, 2024
Update cargo

6 commits in 7e9de3f4ec3708f500bec142317895b96131e47c..7c3904d6c3ed54e8a413023519b55a536ad44d5b
2023-08-13 00:47:32 +0000 to 2023-08-14 20:11:43 +0000
- fix(lints): Doctest extraction should respect `[lints]` (rust-lang/cargo#12501)
- test: relax assertions of panic message (again) (rust-lang/cargo#12500)
- doc(unstable): `cargo test` does not provide `--keep-going` (rust-lang/cargo#12492)
- fix(log): enable ansi color only in terminal (rust-lang/cargo#12488)
- Update cargo-yank.md (rust-lang/cargo#12490)
- test: bypass `rustc --test` impl details for `-Zfuture-incompat-test` (rust-lang/cargo#12491)

r? `@ghost`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants