Added rmw_client, rmw_destroy_client and rmw_service_server_is_available tests #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related with this PR ros2/rmw_fastrtps#447 |
|
|
hidmic
reviewed
Sep 25, 2020
hidmic
force-pushed
the
ahcorde/test/rmw_client
branch
from
91054b3
to
abfeb84
Compare
|
Alright, PR rebased on top of #138. |
|
CI up to
|
|
@ros-pull-request-builder retest this please. |
|
@ros-pull-request-builder retest this please. |
…ble tests Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
hidmic
force-pushed
the
ahcorde/test/rmw_client
branch
from
abfeb84
to
a4e2195
Compare
|
Depends on ros2/rosidl_typesupport_connext#60 to be released and rolling to be upped |
|
@ros-pull-request-builder retest this please. |
3 similar comments
|
@ros-pull-request-builder retest this please. |
|
@ros-pull-request-builder retest this please. |
|
@ros-pull-request-builder retest this please. |
|
It passed ! Finally all green. Merging! |
ahcorde
added a commit
that referenced
this pull request
Oct 9, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde
added a commit
that referenced
this pull request
Oct 21, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing:
Related to this PR
Signed-off-by: ahcorde ahcorde@gmail.com