This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Check allocation of requester and replier #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Brawner <brawner@gmail.com>
dirk-thomas
approved these changes
Aug 26, 2020
|
Testing connext only (`--packages-select rosidl_typesupport_connext_cpp rcl)
|
|
@brawner Is there a reason why this patch is not added to the Eloquent project board? |
|
I keep forgetting it's a 1 year release, sorry. Will backport to all three |
|
The CI builds all pass, so this should be good. |
delete-merged-branch
bot
deleted the
brawner/check-requester-allocation
branch
brawner
added a commit
that referenced
this pull request
Aug 26, 2020
Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
added a commit
that referenced
this pull request
Aug 26, 2020
Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
added a commit
that referenced
this pull request
Aug 26, 2020
Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
added a commit
that referenced
this pull request
Aug 26, 2020
brawner
added a commit
that referenced
this pull request
Aug 27, 2020
brawner
added a commit
that referenced
this pull request
Aug 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was found with the new fault injection tests in
rcl(ros2/rcl#727). If_allocatorfails to allocate, there's an invalid read/write during the RequesterType constructor. The new rcl tests were only for the client, and not the service so the replier didn't have a similar segfault, but the issue still exists there too.Fixes ros2/rcl#767
Signed-off-by: Stephen Brawner brawner@gmail.com