Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
ros2 · Sep 29, 2020 · abfeb84 · abfeb84
1 parent ff8c420
commit abfeb84
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/test_rmw_implementation/test/test_client.cpp b/test_rmw_implementation/test/test_client.cpp
@@ -210,13 +210,24 @@ TEST_F(CLASSNAME(TestClientUse, RMW_IMPLEMENTATION), destroy_client_of_another_i
 TEST_F(CLASSNAME(TestClientUse, RMW_IMPLEMENTATION), service_server_is_available_bad_args)
 {
   bool is_available;
-  rmw_ret_t ret = rmw_service_server_is_available(nullptr, nullptr, &is_available);
+  rmw_ret_t ret = rmw_service_server_is_available(nullptr, client, &is_available);
   EXPECT_EQ(ret, RMW_RET_ERROR) << rmw_get_error_string().str;
   rmw_reset_error();
 
   ret = rmw_service_server_is_available(node, nullptr, &is_available);
   EXPECT_EQ(ret, RMW_RET_ERROR) << rmw_get_error_string().str;
   rmw_reset_error();
+
+  ret = rmw_service_server_is_available(node, client, nullptr);
+  EXPECT_EQ(ret, RMW_RET_ERROR) << rmw_get_error_string().str;
+  rmw_reset_error();
+
+  const char * implementation_identifier = client->implementation_identifier;
+  client->implementation_identifier = "not-an-rmw-implementation-identifier";
+  ret = rmw_service_server_is_available(node, client, &is_available);
+  client->implementation_identifier = implementation_identifier;
+  EXPECT_EQ(ret, RMW_RET_INCORRECT_RMW_IMPLEMENTATION) << rmw_get_error_string().str;
+  rmw_reset_error();
 }
 
 TEST_F(CLASSNAME(TestClientUse, RMW_IMPLEMENTATION), service_server_is_available_good_args)