Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiet a warning when CONNEXTDDS_DIR or NDDSHOME is not found. (backport #158) #161

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Sep 22, 2024

Failing to find those is an acceptable situation; in that case, we will end up just not building rmw_connextdds. Quiet the warning to only a STATUS message so it doesn't cause builds to go yellow.

I found this while trying to run CI for ros2/ci#789, where the RHEL build goes yellow if we don't install Connext.


This is an automatic backport of pull request #158 done by Mergify.

Failing to find those is an acceptable situation; in that
case, we will end up just not building rmw_connextdds.
Quiet the warning to only a STATUS message so it doesn't
cause builds to go yellow.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit c8ffbfd)
@clalancette
Copy link
Contributor

Pulls: #161
Gist: https://gist.githubusercontent.com/clalancette/2d9b3bde667a52b4dc58539a76a00df5/raw/0db7612ce7f987423e4e09faee5d2264478487f9/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_connextdds
TEST args: --packages-above rmw_connextdds
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14591

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor

ahcorde commented Sep 23, 2024

Aarch64 is meant to fail, since we don't currently support Connext there.

@ahcorde ahcorde merged commit 3e97d2a into jazzy Sep 23, 2024
1 check passed
@ahcorde ahcorde deleted the mergify/bp/jazzy/pr-158 branch September 23, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants