Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't install Connext on RHEL jobs. #789

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

clalancette
Copy link
Contributor

@clalancette clalancette commented Aug 20, 2024

We recently realized that we were installing, building, and testing rmw_connextdds on RHEL. However, we don't officially support Connext on RHEL, and we don't have RHEL Connext RPMs either.

In the ROS PMC meeting, we agreed that this combination of factors mean we don't need to install or test Connext on RHEL. This will have two positive outcomes:

  1. The RHEL jobs will finish significantly faster, since they no longer need to download, install, build, and test for Connext/rmw_connextdds.
  2. We'll save some disk space on these jobs, since the Connext binaries are fairly large (about 1GB).

I'll note that while I was in here, I inverted the architecture test since we specifically only want to install Connext on Ubuntu amd64 at present (we also install it on Windows, but that uses a completely separate mechanism).

@claraberendsen FYI.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Contributor Author

Here is a full CI run on Ubuntu Linux (which should install the Connext binaries, and thus build/test rmw_connextdds) and RHEL (which should not install the Connext binaries, and thus should not build/test rmw_connextdds):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status

@ahcorde
Copy link
Contributor

ahcorde commented Aug 21, 2024

  • Linux-rhel Build Status

Included ros2/rmw_connextdds#158

@ahcorde
Copy link
Contributor

ahcorde commented Aug 23, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@clalancette clalancette merged commit c671f75 into master Aug 23, 2024
1 check passed
@clalancette clalancette deleted the clalancette/rhel-dont-install-connext branch August 23, 2024 15:00
@cottsay
Copy link
Member

cottsay commented Aug 23, 2024

We've been shipping binary archives with rmw_connextdds for a while now. Should we mention somewhere that we no longer do that and why?

@clalancette
Copy link
Contributor Author

We've been shipping binary archives with rmw_connextdds for a while now. Should we mention somewhere that we no longer do that and why?

Oh, hm. That's an interesting case. In our default installation, that never could have worked; while we may have shipped rmw_connextdds, we never shipped Connext itself. I guess it could have worked if someone obtained and installed Connext 6.0.1 themselves, but I'm guessing that's a small crowd.

Further, REP-2000 explicitly says we only support Connext on Ubuntu, Windows, and macOS.

Regardless, you are right. I'll make an announcement on Discourse that we've done this, because it will affect Humble, Iron, and Jazzy as well.

@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/removal-of-rmw-connextdds-on-rhel/39268/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants