Quiet a warning when CONNEXTDDS_DIR or NDDSHOME is not found. #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failing to find those is an acceptable situation; in that case, we will end up just not building rmw_connextdds. Quiet the warning to only a STATUS message so it doesn't cause builds to go yellow. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
ahcorde
approved these changes
Aug 21, 2024
|
Pulls: #158
|
|
Aarch64 is meant to fail, since we don't currently support Connext there. There is one failing test on Linux-rhel, but that is also expected right now (and happens on the nightlies). So going ahead and merging this one. |
|
@Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 22, 2024
Failing to find those is an acceptable situation; in that case, we will end up just not building rmw_connextdds. Quiet the warning to only a STATUS message so it doesn't cause builds to go yellow. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit c8ffbfd)
ahcorde
pushed a commit
that referenced
this pull request
Sep 23, 2024
…161) Failing to find those is an acceptable situation; in that case, we will end up just not building rmw_connextdds. Quiet the warning to only a STATUS message so it doesn't cause builds to go yellow. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit c8ffbfd) Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing to find those is an acceptable situation; in that case, we will end up just not building rmw_connextdds. Quiet the warning to only a STATUS message so it doesn't cause builds to go yellow.
I found this while trying to run CI for ros2/ci#789, where the RHEL build goes yellow if we don't install Connext.