Import DurationHandle not DurationType #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
sloretz
force-pushed
the
sloretz__DurationHandle_not_DurationType
branch
from
254078f
to
c2e3a33
Compare
|
CI (build:
|
tfoote
approved these changes
Aug 8, 2024
fujitatomoya
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1255 changed
DurationTypetoDurationHandle, but #1310 still referred toDurationType. That caused the rclpy dev job to fail after both were merged. Running CI on both those PRs in parallel hid the incompatibility.