Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types to qos.py #1255

Merged
merged 15 commits into from
Aug 7, 2024
Merged

Add types to qos.py #1255

merged 15 commits into from
Aug 7, 2024

Conversation

InvincibleRMC
Copy link
Contributor

No description provided.

@InvincibleRMC
Add types to qos.py
0d972bc 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
InvincibleRMC and others added 2 commits March 14, 2024 14:39
@InvincibleRMC
Add missing default value
ddc5a3c 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
TypeAlias 3.8
8946545 
Signed-off-by: Michael Carlstrom <rmc170@case.edu>
fujitatomoya
fujitatomoya approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with minor comment. i would like to ask 2nd review.

rclpy/rclpy/duration.py Show resolved Hide resolved
@fujitatomoya
Copy link
Collaborator

i think we can ignore https://build.ros2.org/job/Rpr__rclpy__ubuntu_noble_amd64/30/testReport/ rpr job that are unrelated.

@InvincibleRMC
Merge remote-tracking branch 'origin/rolling' into qos
895e1db
@InvincibleRMC
Flake8 fixes and simplification
58e2917 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Fix depth=0 error
3e28663 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Fix depth=0 error
2fdf0ec 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
combine error message
b205e77 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
revert to is None
b13be61 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
revert to is None
f7ec33a 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Fix 0 falsey
d2b59d7 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
flip self.depth
15fb2d3 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
sloretz
sloretz requested changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One fix, then the rest LGTM!

rclpy/rclpy/qos.py Outdated Show resolved Hide resolved
@InvincibleRMC
replace or with ternary
973ad8c 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@sloretz
Copy link
Contributor

sloretz commented Aug 2, 2024

Pulls: #1255
Gist: https://gist.githubusercontent.com/sloretz/f3fb2535ace0225ba8d2f32ed9b567ae/raw/85ef195102947295b8d04b9ecb4c33299aa77af6/ros2.repos
BUILD args: --packages-up-to rclpy
TEST args: --packages-select rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14360

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@InvincibleRMC
merge
4f7ba52 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@sloretz
Copy link
Contributor

sloretz commented Aug 7, 2024

Pulls: #1255
Gist: https://gist.githubusercontent.com/sloretz/eb8119e338f75379aa3f5b45f73dd26d/raw/85ef195102947295b8d04b9ecb4c33299aa77af6/ros2.repos
BUILD args: --packages-up-to rclpy
TEST args: --packages-select rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14376

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

sloretz
sloretz approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@sloretz sloretz merged commit 63145fe into ros2:rolling Aug 7, 2024
3 checks passed
@sloretz sloretz mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@InvincibleRMC @fujitatomoya @sloretz