Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types to qos.py #1255

Merged
merged 15 commits into from
Aug 7, 2024
Merged

Add types to qos.py #1255

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
0d972bc
Add types to qos.py
InvincibleRMC Mar 14, 2024
ddc5a3c
Add missing default value
InvincibleRMC Mar 14, 2024
8946545
TypeAlias 3.8
InvincibleRMC Mar 15, 2024
895e1db
Merge remote-tracking branch 'origin/rolling' into qos
InvincibleRMC Jul 31, 2024
58e2917
Flake8 fixes and simplification
InvincibleRMC Jul 31, 2024
3e28663
Fix depth=0 error
InvincibleRMC Jul 31, 2024
2fdf0ec
Fix depth=0 error
InvincibleRMC Jul 31, 2024
b205e77
combine error message
InvincibleRMC Jul 31, 2024
b13be61
revert to is None
InvincibleRMC Jul 31, 2024
f7ec33a
revert to is None
InvincibleRMC Jul 31, 2024
d2b59d7
Fix 0 falsey
InvincibleRMC Jul 31, 2024
15fb2d3
flip self.depth
InvincibleRMC Jul 31, 2024
973ad8c
replace or with ternary
InvincibleRMC Aug 2, 2024
081e784
Merge remote-tracking branch 'upstream/rolling' into qos
sloretz Aug 2, 2024
4f7ba52
merge
InvincibleRMC Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions rclpy/rclpy/duration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
from rclpy.impl.implementation_singleton import rclpy_implementation as _rclpy


class DurationType(Protocol):
class DurationHandle(Protocol):
InvincibleRMC marked this conversation as resolved.
Show resolved Hide resolved
"""Type alias of _rclpy.rcl_duration_t."""

nanoseconds: int
Expand All @@ -41,7 +41,7 @@ def __init__(self, *, seconds: Union[int, float] = 0, nanoseconds: int = 0):
# pybind11 would raise TypeError, but we want OverflowError
raise OverflowError(
'Total nanoseconds value is too large to store in C duration.')
self._duration_handle: DurationType = _rclpy.rcl_duration_t(total_nanoseconds)
self._duration_handle: DurationHandle = _rclpy.rcl_duration_t(total_nanoseconds)

@property
def nanoseconds(self) -> int:
Expand Down Expand Up @@ -106,7 +106,7 @@ def from_msg(cls, msg: builtin_interfaces.msg.Duration) -> 'Duration':
raise TypeError('Must pass a builtin_interfaces.msg.Duration object')
return cls(seconds=msg.sec, nanoseconds=msg.nanosec)

def get_c_duration(self) -> DurationType:
def get_c_duration(self) -> DurationHandle:
return self._duration_handle


Expand Down
Loading