Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creates PublisherHandle and updates publisher.py #1310

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Creates PublisherHandle and updates publisher.py #1310

merged 3 commits into from
Aug 7, 2024

Conversation

InvincibleRMC
Copy link
Contributor

Makes publisher.py type complete.

@InvincibleRMC
PublisherHandle
086e4c2 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
create-publisher more generic
376e24f 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC InvincibleRMC changed the title Creates PublisherHandle and updatets publisher.py Creates PublisherHandle and updates publisher.py Jul 6, 2024
fujitatomoya
fujitatomoya approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

@sloretz
Merge branch 'rolling' into publisherhandle
79e5db4 
Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
@sloretz
Copy link
Contributor

sloretz commented Aug 7, 2024

Pulls: #1310
Gist: https://gist.githubusercontent.com/sloretz/9cf4aec08842e017c47b9372440b143c/raw/14a972e3ea106f030f30161b491531837aa7e7ca/ros2.repos
BUILD args: --packages-up-to rclpy
TEST args: --packages-select rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14378

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@sloretz sloretz merged commit d97669b into ros2:rolling Aug 7, 2024
3 checks passed
@sloretz sloretz mentioned this pull request Aug 8, 2024
Merged
@InvincibleRMC InvincibleRMC deleted the publisherhandle branch September 13, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@InvincibleRMC @sloretz @fujitatomoya