Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types to parameter.py. #1246

Merged
merged 27 commits into from
Aug 2, 2024
Merged

Add types to parameter.py. #1246

merged 27 commits into from
Aug 2, 2024

Conversation

InvincibleRMC
Copy link
Contributor

No description provided.

@fujitatomoya fujitatomoya self-requested a review March 12, 2024 19:06
InvincibleRMC and others added 8 commits March 27, 2024 14:25
@InvincibleRMC
Add types to parameter.py
51d410d 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@clalancette @InvincibleRMC
Revert "Add types to TypeHash and moved away from __slots__ usage (ro…
7661294 
…s2#1232)" (ros2#1243)

This reverts commit b06baef.

Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Add back Type hash __slots__ and add test cases. (ros2#1245)
98ba24c 
* Add types to TypeHash and add test cases

Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Add types to context.py (ros2#1240)
c60ba6f 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Add types to qos_overriding_options.py (ros2#1248)
0bca600 
Signed-off-by: Michael Carlstrom <rmc170@case.edu>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@clalancette @InvincibleRMC
Small fixes for modern flake8. (ros2#1264)
51889a4 
It doesn't like to compare types with ==, so switch to
isinstance as appropriate.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Add types to time_source.py (ros2#1259)
6b5b793 
* Add types to time_source.py

Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
fix small bug
fe29332 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Merge branch 'rolling' into parameters
2bd92ed
@InvincibleRMC
Merge branch 'rolling' into parameters
e879246
@InvincibleRMC
Switch to overloads to avoid mypy3737
2655545 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Update parameter declaration from Node
dc58c0b 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
add back rclpy.
da1251b 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Fix flake8 imports
f7fa348 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Add proper array.array[]
d60df58 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Update types of declare_parameter, declare_parameters api
44f4fba 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Add non conflicting types back to constructor
8c56519 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Move sys import
7f36fa2 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Update error message
5fba36d 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Add default value for generic Parameter
f2466c1 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Add explanation comment
f01ca94 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Add TypeVar import inside else case
a646d8a 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Merge branch 'rolling' into parameters
23c828a
@InvincibleRMC
push to rerun ci
6acc79c 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
push to rerun ci
739b97a 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Switch back to union
ae10551 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
sloretz
sloretz approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@sloretz
Copy link
Contributor

sloretz commented Aug 2, 2024

Gist: https://gist.githubusercontent.com/sloretz/914d83d9692ee5a19b612230bfbb0a1f/raw/ad37a28a261a83b1d57b1191b06fd7aae064cba4/ros2.repos
BUILD args: --packages-up-to rclpy
TEST args: --packages-select rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14355

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@sloretz sloretz merged commit db98d90 into ros2:rolling Aug 2, 2024
3 checks passed
@InvincibleRMC InvincibleRMC deleted the parameters branch September 13, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz approved these changes

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

@fujitatomoya fujitatomoya Awaiting requested review from fujitatomoya

Assignees

@sloretz sloretz

@fujitatomoya fujitatomoya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@InvincibleRMC @sloretz @fujitatomoya @clalancette