Add types to TypeHash and moved away from __slots__ usage #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
InvincibleRMC
requested review from
sloretz and
adityapande-1995
as code owners
fujitatomoya
approved these changes
Feb 28, 2024
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
sloretz
approved these changes
Mar 8, 2024
|
CI (repos file build:
|
It turns out that this isn't enough CI; this is causing failures in CI now: https://ci.ros2.org/job/ci_linux/20452/testReport/junit/ros2cli.ros2cli.test/test_daemon/test_get_subscriptions_info_by_topic/ . I'm going to propose a revert here. |
clalancette
added a commit
that referenced
this pull request
Mar 9, 2024
)" This reverts commit b06baef.
InvincibleRMC
added a commit
to InvincibleRMC/rclpy
that referenced
this pull request
Mar 24, 2024
* Add types to TypeHash and moved away from __slots__ usage Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * remove docstring types Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> --------- Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
InvincibleRMC
pushed a commit
to InvincibleRMC/rclpy
that referenced
this pull request
Mar 24, 2024
InvincibleRMC
pushed a commit
to InvincibleRMC/rclpy
that referenced
this pull request
Mar 27, 2024
sloretz
added a commit
that referenced
this pull request
May 3, 2024
* First draft of generics Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Fix Generic Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add legacy Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Fix import order Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * fix import order Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add Docstrings Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add Docstrings Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add generics support to Node Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Update type_support.py Signed-off-by: Michael Carlstrom <36806982+InvincibleRMC@users.noreply.github.com> Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to expand_topic_name (#1238) Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Creates Enum wrapper for ClockType and ClockChange (#1235) * Testing out Enum wrapper for ClockType * convert to rcl_clock_type_t * Update create_time_point Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types (#1231) Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to exceptions.py (#1241) * Add types to exception * Add type checking guard * Fix NotInitializedException * Add missing defualt Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * added python3-yaml (#1242) Signed-off-by: SnIcK <ido.samuelson@gmail.com> Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to duration.py (#1233) * Add types to logging_service.py (#1227) * add types to logging_service * Add types to duration.py * Add newlines for class definintions * update type alias name * Update to use Protocols Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add Static Typing to Validate files (#1230) * Add types to validate files Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * remove type annotations from docstrings Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * removed other type annotated docstrings Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> --------- Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to TypeHash and moved away from __slots__ usage (#1232) * Add types to TypeHash and moved away from __slots__ usage Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * remove docstring types Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> --------- Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Time.py Types (#1237) * Start typing time.py Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Testing out Enum wrapper for ClockType Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * convert to rcl_clock_type_t Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Undo Change to time_point.cpp Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Update create_time_point Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Lint fixes Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add debug message Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Remove test file Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Try extending the type assert Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to logging_service.py (#1227) * add types to logging_service Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to duration.py Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add newlines for class definintions Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * update type alias name Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Remove newline Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Merge? Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Fix failed merge Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Update to use Protocols Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Fix import error Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to time.py Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Linty Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> --------- Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Revert "Add types to TypeHash and moved away from __slots__ usage (#1232)" (#1243) This reverts commit b06baef. Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add back Type hash __slots__ and add test cases. (#1245) * Add types to TypeHash and add test cases Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to context.py (#1240) Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * fix pub and sub Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Update LifecyclePublisher Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Fix docstring Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * serialization generic Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * serialization generic Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Update type_support.py Signed-off-by: Michael Carlstrom <36806982+InvincibleRMC@users.noreply.github.com> --------- Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> Signed-off-by: Michael Carlstrom <36806982+InvincibleRMC@users.noreply.github.com> Signed-off-by: SnIcK <ido.samuelson@gmail.com> Signed-off-by: Shane Loretz <sloretz@intrinsic.ai> Co-authored-by: SnIcK <ido.samuelson@gmail.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Shane Loretz <sloretz@intrinsic.ai>
sloretz
added a commit
that referenced
this pull request
Aug 2, 2024
* Add types to parameter.py Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Revert "Add types to TypeHash and moved away from __slots__ usage (#1232)" (#1243) This reverts commit b06baef. Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add back Type hash __slots__ and add test cases. (#1245) * Add types to TypeHash and add test cases Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to context.py (#1240) Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to qos_overriding_options.py (#1248) Signed-off-by: Michael Carlstrom <rmc170@case.edu> Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Small fixes for modern flake8. (#1264) It doesn't like to compare types with ==, so switch to isinstance as appropriate. Signed-off-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to time_source.py (#1259) * Add types to time_source.py Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * fix small bug Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Switch to overloads to avoid mypy3737 Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Update parameter declaration from Node Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * add back rclpy. Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Fix flake8 imports Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add proper array.array[] Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Update types of declare_parameter, declare_parameters api Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add non conflicting types back to constructor Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Move sys import Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Update error message Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add default value for generic Parameter Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add explanation comment Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add TypeVar import inside else case Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * push to rerun ci Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * push to rerun ci Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Switch back to union Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> --------- Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> Signed-off-by: Michael Carlstrom <rmc170@case.edu> Signed-off-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Shane Loretz <sloretz@intrinsic.ai>
sloretz
added a commit
that referenced
this pull request
Aug 5, 2024
* First draft of generics Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Fix Generic Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add legacy Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Fix import order Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * fix import order Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add Docstrings Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add Docstrings Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add generics support to Node Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Update type_support.py Signed-off-by: Michael Carlstrom <36806982+InvincibleRMC@users.noreply.github.com> Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to expand_topic_name (#1238) Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Creates Enum wrapper for ClockType and ClockChange (#1235) * Testing out Enum wrapper for ClockType * convert to rcl_clock_type_t * Update create_time_point Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types (#1231) Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to exceptions.py (#1241) * Add types to exception * Add type checking guard * Fix NotInitializedException * Add missing defualt Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * added python3-yaml (#1242) Signed-off-by: SnIcK <ido.samuelson@gmail.com> Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to duration.py (#1233) * Add types to logging_service.py (#1227) * add types to logging_service * Add types to duration.py * Add newlines for class definintions * update type alias name * Update to use Protocols Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add Static Typing to Validate files (#1230) * Add types to validate files Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * remove type annotations from docstrings Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * removed other type annotated docstrings Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> --------- Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to TypeHash and moved away from __slots__ usage (#1232) * Add types to TypeHash and moved away from __slots__ usage Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * remove docstring types Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> --------- Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Time.py Types (#1237) * Start typing time.py Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Testing out Enum wrapper for ClockType Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * convert to rcl_clock_type_t Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Undo Change to time_point.cpp Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Update create_time_point Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Lint fixes Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add debug message Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Remove test file Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Try extending the type assert Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to logging_service.py (#1227) * add types to logging_service Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to duration.py Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add newlines for class definintions Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * update type alias name Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Remove newline Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Merge? Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Fix failed merge Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Update to use Protocols Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Fix import error Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to time.py Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Linty Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> --------- Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Revert "Add types to TypeHash and moved away from __slots__ usage (#1232)" (#1243) This reverts commit b06baef. Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add back Type hash __slots__ and add test cases. (#1245) * Add types to TypeHash and add test cases Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to context.py (#1240) Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * fix pub and sub Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Update LifecyclePublisher Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Fix docstring Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Start implementation Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Ungeneric? Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Stuff Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * serialization generic Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * serialization generic Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Update type_support.py Signed-off-by: Michael Carlstrom <36806982+InvincibleRMC@users.noreply.github.com> * Client Service Generic Implementation Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Fix debug relative import Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Update imports Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add generics to node.py Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Update import order Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Remove double bracket Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> --------- Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> Signed-off-by: Michael Carlstrom <36806982+InvincibleRMC@users.noreply.github.com> Signed-off-by: SnIcK <ido.samuelson@gmail.com> Co-authored-by: SnIcK <ido.samuelson@gmail.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Shane Loretz <sloretz@intrinsic.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds static typing to type_hash.py. In the constructor I switch away from
**kwargsto explicit variable names. If there is some reason the**kwargsis preferred for now I can use Any. Just let me know so I can add a TODO to use Unpack[] when python 3.12 is supported. Or I suppose I could use typing_extensions package to use Unpack on older versions of python.