Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Arguments in launch files and enable their reuse. #76
Use Arguments in launch files and enable their reuse. #76
Changes from 9 commits
e6398af
bd426cb
69ecef9
5f58183
30f3f94
a550d90
aa9031b
0836718
da81d3e
8f696d4
6101e06
572bfc9
0d10b4b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this demo the default rviz configuration file did not set up correctly the fixed frame (I'm guessing it's
odom
) nor did it showed the Robot Model.After fixing this and sending the velocity command the demo runs fine.
One thing I noticed is the velocity being correctly updated in the
/joint_states
while the wheel positions is fixed to zero.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jordan-palacios I will try to propose a fix by tomorrow morning.