Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensuring the execution of 'Router.loadEvents' #1741

Closed
wants to merge 1 commit into from
Closed

Ensuring the execution of 'Router.loadEvents' #1741

wants to merge 1 commit into from

Conversation

kaisermann
Copy link
Contributor

Sometimes the DOMContentLoaded event has already been fired. To make sure the loadEvents() method is always executed, we should check the document.readyState and, if it’s already defined as "complete", execute the callback immediately.

Reference

@QWp6t QWp6t mentioned this pull request Nov 7, 2016
Merged
@retlehs
Copy link
Member

retlehs commented Nov 17, 2016

closed by #1751

@retlehs retlehs closed this Nov 17, 2016
QWp6t referenced this pull request Jan 4, 2017
@QWp6t
Use $.fn.ready() (reverts 724d550)
e7fccbe
@QWp6t QWp6t mentioned this pull request Feb 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaisermann @retlehs