Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jQuery Dependencies #2022

Closed
wants to merge 1 commit into from
Closed

Remove jQuery Dependencies #2022

wants to merge 1 commit into from

Conversation

asuh
Copy link

@asuh asuh commented Feb 7, 2018

Removing jQuery dependency from main files since the rest of this is ES-2015 compatible

Document.readyState snippet added from this example:
https://www.sitepoint.com/jquery-document-ready-plain-javascript/#plainjavascriptreadyalternative

@QWp6t
Copy link
Member

QWp6t commented Feb 7, 2018

We decided against this and chose to use jQuery because jQuery is already a WordPress dependency and numerous WordPress plugins rely on it. That's not to mention that Sage comes with Bootstrap by default, which depends on jQuery.

See also: #1741

@QWp6t QWp6t closed this Feb 7, 2018
@asuh
Copy link
Author

asuh commented Feb 7, 2018

Right, I understand. The thought was that Sage provides the option to go with no CSS framework and the resources/assets/scripts files are for asset building. These are the only two files in /scripts that require jQuery so I submitted this to make it consistent with all other files in this directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants