Sage 9-alpha.4

[QWp6t]

I haven't done a whole lot of testing with this so I don't wanna push it as an update just yet.

Will do some more tests and tag a new release probably sometime this week. If all goes well with this release, then the next step is adding Blade support.

If you decide to test this, be sure to re-activate your theme.

[QWp6t]

This PR closes: #1715, #1719, #1739, #1741, #1742, #1743

[nathanielks]

Just tested this on a theme I'm working on. Javascript is loading, but for some reason styles aren't being compiled?

[JonMasterson]

I encountered an issue related to the 'stylesheet' > 'template' revision in functions.php (not using Bedrock). With the 'template' change, theme name was missing from my css/js paths. Also, image assets went missing — image file paths (which should point to '/dist/images') contained '/templates/' in the file path. When I reverted functions.php, all was well.

[QWp6t]

@nathanielks
If you mean they're not written to your filesystem when you do npm start, that's because they're in webpack's internal filesystem, which sits in memory. This is faster. When you visit the proxy server, they should still be served.

@JonMasterson
You just have to reactivate your theme. That will solve your issue.

[nathanielks]

@QWp6t yup, I'm aware! The stylesheets weren't loaded even when visiting the proxy. I'll test a vanilla clone and see what that gives me

[JonMasterson]

Doh! Didn't notice the hook — Works great. Thanks!

[giacomoalonzi]

@nathanielks same problem here, let me know if you solve it! thx

[retlehs]

@giacomoalonzi try removing your node_modules directory and switching to yarn

[nathanielks]

@retlehs @giacomoalonzi I was already using yarn and nuked node_modules to no avail... an interesting clue is the output for yarn start in alpha4 for me does not include any of the standard Webpack jargon and doesn't appear to run anything when I save a file that would trigger an update in alpha3.

[nathanielks]

Mmmm'k. Vanilla alpha4 does have the webpack jargon, so I'm believing I didn't merge everything correctly. I had a bunch of merge conflicts trying to merge 3 and 4 in an existing theme, so it was a bunch of manual merge resolution.

[nathanielks]

Welp, insert foot into mouth. It works fine! The only difference for me is the Webpack hullabuhloo still isn't being output in yarn start, but it does in fact perform updates in the browser.

[nathanielks]

Now, one thing that I have noticed (that's semi annoying) is that on subsequent rebuilds without refreshing the page, updated JS isn't really because the router is only loaded on document.ready() (this also existed in alpha3). @QWp6t is the solution here to have it trigger on document.ready and on rebuilds? Does HMR broadcast any events we can hook into? I'm just not sure where to start. I imagine we'll have to have some method of removing event listeners as well before the code is evaluated...

[nathanielks]

Oh, and for whatever reason even reloading the page doesn't update the js. I have to ctrl-c yarn start and restart it to get the updates in the browser.

[QWp6t]

@nathanielks

I'm not sure if there's an event, but this should work:

if (module.hot) {
  new Router(routes).loadEvents();
}

Obviously an event would be better, though.

[derkjn]

Side note, this is already not compatible with webpack@2.1.0-beta.26. See here.
The package.json should be updated accordingly.

[wassim]

I can't get isotope and a couple of other scripts to work with DOM ready. What was the reason for 724d550 ?

[derkjn]

Tested this today on a fairly big project with lots of other deps and stuff. All working good on my end! Cheers @QWp6t!