Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix forward compatibility with v6-30 #12845

Merged
merged 1 commit into from
May 22, 2023
Merged

Fix forward compatibility with v6-30 #12845

merged 1 commit into from
May 22, 2023

Conversation

pcanal
Copy link
Member

@pcanal pcanal commented May 18, 2023

In v6-30 we no longer record the kIsOnHeap and kNotDeleted, however older version of ROOT do not yet set them properly when reading. This leads to spurrious error message like:

Error in <TList::Clear>: A list is accessing an object (0x2d77b50) already deleted (list name = TList)

But also failure in some case where action is not taken because the object is incorrect thought to be already deleted.

@pcanal
fBits read: preserve kIsOnHeap, always set kNotDeleted.
ac89487 
Rather than reading from the file the value of kIsOnHeap, preserve the value that was
calculated at object creation time (i.e. in the current execution).  For example, for
an embedded object (inside an object created on the heap or stack), the bit always
need to be off (i.e. it can never be explicitly deleted)
@pcanal pcanal requested a review from jblomer May 18, 2023 17:29
@pcanal pcanal requested a review from Axel-Naumann as a code owner May 18, 2023 17:29
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on mac12/noimt.
Running on macphsft17.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu18.04/nortcxxmod.
Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@pcanal pcanal self-assigned this May 18, 2023
@phsft-bot
Copy link
Collaborator

Build failed on mac11/cxx14.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@pcanal pcanal merged commit 8c75af5 into root-project:v6-28-00-patches May 22, 2023
@makortel
Copy link

makortel commented Feb 6, 2024

Was this fix already backported to earlier ROOT releases than 6.28?

This was referenced Feb 6, 2024
Merged
Closed
@pcanal
Copy link
Member Author

pcanal commented Feb 6, 2024

Yes, see the full list of the side panel, it includes v6.26, v6.24 and more. However most have not been tagged yet.

@makortel
Copy link

makortel commented Feb 6, 2024

Thanks!

@smuzaffar smuzaffar mentioned this pull request Feb 7, 2024
Closed
iarspider added a commit to cms-sw/cmsdist that referenced this pull request Feb 12, 2024
@iarspider
[12_4_X] Cherry-pick ROOT fixes for forward compatibility
6e5d61c 
Cherry-pick changes from root-project/root#10642 and root-project/root#12845
@iarspider iarspider mentioned this pull request Feb 12, 2024
Merged
iarspider added a commit to cms-sw/cmsdist that referenced this pull request Feb 12, 2024
@iarspider
[12_5_X] Cherry-pick ROOT fixes for forward compatibility
3255f10 
Cherry-pick root-project/root#12845, the root-project/root#10642 is already included in base
@iarspider iarspider mentioned this pull request Feb 12, 2024
Closed
iarspider added a commit to cms-sw/cmsdist that referenced this pull request Feb 12, 2024
@iarspider
[12_6_X] Cherry-pick ROOT fixes for forward compatibility
c7e39ba 
Cherry-pick root-project/root#12845, the root-project/root#10642 is already included in base
@iarspider iarspider mentioned this pull request Feb 12, 2024
Merged
iarspider added a commit to cms-sw/cmsdist that referenced this pull request Feb 13, 2024
@iarspider
[12_6_X] Cherry-pick ROOT fixes for forward compatibility
baba29b 
Cherry-pick root-project/root#12845, the root-project/root#10642 is already included in base
@iarspider iarspider mentioned this pull request Mar 7, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jblomer jblomer Awaiting requested review from jblomer

@Axel-Naumann Axel-Naumann Awaiting requested review from Axel-Naumann Axel-Naumann is a code owner

Assignees

@pcanal pcanal

Labels
in:I/O priority:critical
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcanal @phsft-bot @makortel