Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] Cherry-pick ROOT fixes for forward compatibility #9007

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

iarspider
Copy link
Contributor

Cherry-pick changes from root-project/root#10642 and root-project/root#12845

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_12_4_X/master.

@iarspider, @smuzaffar, @aandvalenzuela can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 12, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4400c5/37375/summary.html
COMMIT: 6e5d61c
CMSSW: CMSSW_12_4_X_2024-02-11-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9007/37375/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 14 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3766083
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3766053
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 167 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

@makortel , as suggested in cms-sw/cmssw#43882 , this includes root-project/root#10642 and root-project/root#12845 for 12.4.X . Tests look good and I am fine with including it for next 12.4.X IB. Do you want to run any tests before we merge it. cmssw PR area based on this change is available under /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9007/37375

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_4_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link

+1

@cmsbuild cmsbuild merged commit e9dad0a into IB/CMSSW_12_4_X/master Feb 16, 2024
9 checks passed
@iarspider iarspider deleted the iarspider-patch-1 branch February 19, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants