Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read errors in opening ROOT 6.30 files in earlier ROOT versions #43882

Closed
makortel opened this issue Feb 6, 2024 · 14 comments
Closed

Read errors in opening ROOT 6.30 files in earlier ROOT versions #43882

makortel opened this issue Feb 6, 2024 · 14 comments

Comments

@makortel
Copy link
Contributor

makortel commented Feb 6, 2024

It turned out that files written in ROOT 6.30 (or later) are not readable in earlier ROOT versions "out of the box". The problem has been fixed for ROOT 6.28 in root-project/root#12845 . The error is along

      [d] Fatal Root Error: @SUB=TList::Clear
A list is accessing an object (0x154e2060ea40) already deleted (list name = TList)

This issue is for us to track what ROOT fixes we need to backport to which CMSSW release cycles.

The problem was observed e.g. in #43827 (comment)

@makortel
Copy link
Contributor Author

makortel commented Feb 6, 2024

assign core

@makortel
Copy link
Contributor Author

makortel commented Feb 6, 2024

type root

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2024

New categories assigned: core

@Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2024

A new Issue was created by @makortel Matti Kortelainen.

@antoniovilela, @Dr15Jones, @smuzaffar, @sextonkennedy, @makortel, @rappoccio can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Feb 6, 2024

For the purpose of potentially running the HLT step in a future Run 3 Ultra Legacy MC production in a similar way as in Run 2 Ultra Legacy production, we'd need the ROOT fix backported down to 12_4_X, which used ROOT 6.24.

If the "reading newer files with older ROOTs" would be needed for something else, we might have backport to even earlier releases.

FYI @cms-sw/upgrade-l2

@srimanob
Copy link
Contributor

srimanob commented Feb 6, 2024

Thanks @makortel for following up on this.

I see on the ROOT PR that you ask if there will be a backport down to release older than 6.28.

@makortel
Copy link
Contributor Author

makortel commented Feb 6, 2024

@smuzaffar According to Philippe the fix has been backported down to 6.14, but not tagged yet in all release series. Do you want to wait for the tags, or could we update ROOT already now in all release cycles down to CMSSW_12_4_X?

@smuzaffar
Copy link
Contributor

smuzaffar commented Feb 7, 2024

@makortel , we do not need root tag but for CMSSW 12.4.X we are using root 6.24 and these are the changes which root has on top of what we are using in 12.4.X. Do you think it is safe to get all these root updates in 12.4? I prefer to just cherry pick the fix on top of cms root branch

@smuzaffar
Copy link
Contributor

root-project/root@5858905...v6-26-00-patches are the root 6.26-patches branch (used in CMSSW 13 release cycle) changes

@makortel
Copy link
Contributor Author

makortel commented Feb 7, 2024

we do not need root tag but for CMSSW 12.4.X we are using root 6.24 and these are the changes which root has on top of what we are using in 12.4.X. Do you think it is safe to get all these root updates in 12.4? I prefer to just cherry pick the fix on top of cms root branch

On a quick look the list of commits looked like there were some fixes that sounded useful, and some that could warrant more thorough testing for a "closed" release cycle. I'd be fine with just cherry-picking the fix.

One commit that caught my eye was from root-project/root#10641 that you had asked to be backported to 6.24 root-project/root#10576 (comment) :)

@makortel
Copy link
Contributor Author

+core

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants