Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md #720

Merged
merged 2 commits into from
Aug 5, 2020
Merged

Update CHANGELOG.md #720

merged 2 commits into from
Aug 5, 2020

Conversation

elandini84
Copy link
Contributor

Added Fixed section to Unreleased major and added a brief comment regarding this pull request

@traversaro
Copy link
Member

Thanks @elandini84 . In this case it is not a big problem and I can accept this PRs as they are, but for the future note that is a common practice to keep related changes as part of the same Pull Request. To add new commits to an existing PR (for example #719), you can simply push new commits to the elandini84:fix_segfault_yarprobotstatepublisher_onread branch, or if you want to to the modifications via the Web UI, you can just edit the branch connected to the existing PR by selecting it in the GitHub branch selector, see : https://github.com/elandini84/idyntree/tree/fix_segfault_yarprobotstatepublisher_onread .

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Silvio Traversaro <pegua1@gmail.com>
@elandini84
Copy link
Contributor Author

Thanks @elandini84 . In this case it is not a big problem and I can accept this PRs as they are, but for the future note that is a common practice to keep related changes as part of the same Pull Request. To add new commits to an existing PR (for example #719), you can simply push new commits to the elandini84:fix_segfault_yarprobotstatepublisher_onread branch, or if you want to to the modifications via the Web UI, you can just edit the branch connected to the existing PR by selecting it in the GitHub branch selector, see : https://github.com/elandini84/idyntree/tree/fix_segfault_yarprobotstatepublisher_onread .

Thanks for the clarification. I'll avoid the same mistake in the future.

@traversaro traversaro merged commit a14592a into robotology:devel Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants