[TEST] Test for Gateways functionality (RT-1906)

[darkdarkdragon]

No description provided.

[vhpoet]

@darkdarkdragon I really like the direction you're taking on writing e2e tests, can you please check out Protractor Page Objects, and let me know what do you think about it?

[darkdarkdragon]

I'm used Page Objects pattern, at least that's what I think about it :)
In fact, I'm based my code on this http://www.thoughtworks.com/insights/blog/using-page-objects-overcome-protractors-shortcomings as a template.
Do you think I something can be improved in code that I wrote?

BTW, for testing we are using "grunt-mocha-protractor". But it has very olde protractor in dependency.
I think we must do something about it while there is not too much tests written.

[vhpoet]

@darkdarkdragon I was thinking if we can simplify this.

Protractor example is
this.nameInput = element(by.model('yourName'));
Our code is
nameInput: { get: function () { return element(by.model('yourName')) }},

What do you think?

P.S. Yea, looks like our protractor version is very old. I'll work on it.

[darkdarkdragon]

I just choose template with getters because I didn't know if element can be created before even page isn't available.
But as I see now in documentation, it's ok to create them early.
So yes, this can be simplified.

[vhpoet]

@darkdarkdragon awesome, don't even know why is this guy doing it in a hard way.. maybe it's an outdated article, donno.

[vhpoet]

then(function() { done(); }) this could be simplified to then(done)

[vhpoet]

LGTM

[vhpoet]

@darkdarkdragon ok, good for now.

[mrajvanshy]

LGTM

[ripplebot]

Ready to merge: Travis build checks out, most recent commit looks good to mrajvanshy, vhpoet.

[vhpoet]

@darkdarkdragon gateway tests are broken, can you please check?

[darkdarkdragon]

@vhpoet one fix is here #1871

[darkdarkdragon]

@vhpoet second fix #1872