[TASK] RT-2525 e2e tests for account rename #1748
Conversation
|
LGTM |
| function pressRenameSubmit() { | ||
| $("form[name='renameForm'] button[type='submit']").click().then(function() { | ||
|
|
||
| browser.wait(function () { |
There was a problem hiding this comment.
You can make this more concise with browser.wait($("div.showPublic div.alert-success").isDisplayed).
There was a problem hiding this comment.
Agree, please make the change
There was a problem hiding this comment.
I'll wait until you merge #1766 - I've added useful utility function there
|
Merged #1766 |
darkdarkdragon
force-pushed
the
develop-RT-2525
branch
from
50fcb41
to
6efdbe9
Compare
use utility functions to make code shorter
darkdarkdragon
force-pushed
the
develop-RT-2525
branch
from
6efdbe9
to
156bcca
Compare
|
|
||
|
|
||
| it('should rename user', function(done) { | ||
| protractor.getInstance().ignoreSynchronization = true; |
There was a problem hiding this comment.
because, without that, protractor will wait for angular to finish all of it internal jobs.
but, when you submit password, ripple client start timer for 5 minutes to expire this password.
so protractor will wait for that to finish and will run out of time for test.
it took long time to identify this one.
There was a problem hiding this comment.
@darkdarkdragon ok, makes sense.
|
LGTM |
[TASK] RT-2525 e2e tests for account rename
No description provided.