Pret merge (15th of October) #5527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed generated files (layouts.h, map_groups.h) from git.
Added some documentation and simplified dependency scanning.
Secondary expansion is redundant.
Slight storage system documentation
Clean up defines lacking spaces
UB fix in battle_transition.c
preproc: support arbitrary expressions in enums
…ld-makefile-cleanup
[Build System Rewrite] Refactored `Makefile`
…ld-scaninc-speed
…ld-music-config
Fix incorrect point macros in contest_ai_script.inc
# Conflicts: # Makefile # include/battle.h # include/battle_main.h # include/battle_util.h # include/data.h # make_tools.mk # map_data_rules.mk # src/battle_setup.c # src/fieldmap.c
Everytime I make a new project I suffer, please merge.
Bugfix for cable car hikerGraphicsIds array
Remove explicit symbol sizes in sym_common.txt
Ignore mGBA screenshots
Yes, this is honestly overkill, as it doesn't actually fix any behavioral bugs, but I was suggested to do this. This was a typo made in the source that GameFreak made, and the compiler warns against this. I opened a PR in pokeemerald expansion and was suggested to open one here.
Fix typo: | should be || in Task_TryFieldPoisonWhiteOut
Bassoonian
reviewed
Oct 16, 2024
|
Ready for review! |
Bassoonian
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pret merge - DO NOT SQUASH!
Supersedes #5352
Description
Makefilepret/pokeemerald#1950Conflicts:
make_tools.mkMakefilemap_data_rules.mk.github/pull_request_template.md.github/workflows/build.ymlcommon_syms/battle_main.txtcommon_syms/main.txtinclude/battle_main.hinclude/battle_util.hinclude/battle.hinclude/data.hinclude/gba/defines.hsrc/battle_main.csrc/battle_setup.csrc/contest.csrc/field_specials.csrc/fieldmap.csrc/load_save.csrc/main.csrc/mini_printf.csrc/random.c.gitignoreld_script_modern.ldld_script.ldFeature(s) this PR does NOT handle:
Not checking checksum, as the amount of changes done in the last month+ has made it difficult to properly determine what made
agbcc's checksum change.However, for the sake of documentation, here's the PRs that were confirmed to have modified the checksum:
Discord contact info
AsparagusEduardo