Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor toolchain fixes #2031

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Conversation

GriffinRichards
Copy link
Member

@GriffinRichards GriffinRichards commented Sep 14, 2024

  • Fix a bug with [Build System Rewrite] Massive build speed improvement via scaninc changes #1954. If generating the .o failed due to a non-existent dependency, the .d file wasn't regenerated (e.g. for some #include "foo.h", if the build failed because foo.h didn't exist then removing the #include wouldn't allow the build to proceed)
  • Clarify the error message when a dependency file doesn't exist by allowing scaninc to ignore it (example below)
  • Silence some warnings when a .d file doesn't exist yet
  • Silence some warnings for -Wunqualified-std-cast-call
  • Explicitly default KEEP_TEMPS to 0

Example -- given #include "foo.h" in parent.c where foo.h doesn't exist...
before:

make: *** No rule to make target `src/foo.h', needed by `build/emerald/src/parent.o'.  Stop.

after:

src/parent.c:<line_num>:<col_num>: fatal error: foo.h: No such file or directory
    <line_num> | #include "foo.h"

@GriffinRichards GriffinRichards merged commit 473e062 into pret:master Sep 19, 2024
1 check passed
@GriffinRichards GriffinRichards deleted the fix-toolchain branch September 19, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant