Add support for overworld sprite gender differences + add all the sprites #5394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hedara90
added
category: pokemon
hedara90
reviewed
Sep 19, 2024
|
Poke me when this is ready |
|
On hold as I am currently waiting for a master merge into upcoming |
|
Master has been merged and I have updated the branch, so this PR is no longer on hold and can be reviewed |
hedara90
reviewed
Sep 30, 2024
|
When setting |
|
Addressed the sprite reviews, and fixed the OW_POKEMON_OBJECT_EVENTS compilation fail |
hedara90
reviewed
Oct 3, 2024
|
Addressed |
hedara90
approved these changes
Oct 4, 2024
fdeblasio
pushed a commit
to fdeblasio/pokeemerald-expansion
that referenced
this pull request
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows overworld sprites and followers to have gender differences defined.
Adds sprites for all current pokemon gender differences.
Issue(s) that this PR fixes
Fixes #5124
People who collaborated with me in this PR
All the sprites for gender differences that weren't from GF came from here: https://www.deviantart.com/larryturbo/art/OWs-of-Missing-Gender-Variants-Normal-Shiny-878691887
Discord contact info
kittenchilly