OBJ_EVENT_GFX_SPECIES_SHINY does not entirely work

[Nopinou]

Description

This looks like a shiny Unown-K to me.

Strangely, going in a full screen UI and reloading the whole OW displays the correct shiny OW. One thing I know to be broken as well but is not shown in the gif is the shiny OW in a map connection instead of a warp.

Steps to reproduce: add the following OBJ_EVENTS to InsideOfTruck's map.json:
{
"graphics_id": "OBJ_EVENT_GFX_SPECIES(MAGIKARP)",
"x": 1,
"y": 1,
"elevation": 3,
"movement_type": "MOVEMENT_TYPE_WALK_IN_PLACE_DOWN",
"movement_range_x": 0,
"movement_range_y": 0,
"trainer_type": "TRAINER_TYPE_NONE",
"trainer_sight_or_berry_tree_id": "0",
"script": "NULL",
"flag": "0"
},
{
"graphics_id": "OBJ_EVENT_GFX_SPECIES_SHINY(MAGIKARP)",
"x": 2,
"y": 1,
"elevation": 3,
"movement_type": "MOVEMENT_TYPE_WALK_IN_PLACE_DOWN",
"movement_range_x": 0,
"movement_range_y": 0,
"trainer_type": "TRAINER_TYPE_NONE",
"trainer_sight_or_berry_tree_id": "0",
"script": "NULL",
"flag": "0"
}

While trying to fix it, I found a few things that seem strange to me:

• lines 1687 to 1691 are a duplicate of lines 1681 to 1685 in src/event_object_movement.c
• In TrySetupObjectEventSprite, graphicsId is used before checking if shiny and changing value
• Add support for overworld sprite gender differences + add all the sprites #5394 made changes in CreateObjectGraphicsSprite that bring the behavior mentionned in the previous line

Version

upcoming (Edge)

Upcoming/master Version

No response

Discord contact info

Nopinou#8678

[iriv24]

ive narrowed this issue down to the lines removed here:

however, adding those lines back re-introduces an issue from #5470 that was fixed