Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement members permissions #128

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

akondas
Copy link
Member

@akondas akondas commented Apr 29, 2020

Last from #56

Organization member role permissions:

Member

  • manage packages (stats, webhook, update)
  • manage organization tokens
  • see other members

Owner

  • add package
  • invite members
  • can remove package
  • organization configuration
  • remove organization

@akondas akondas requested a review from karniv00l April 29, 2020 20:26
@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #128 into members will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             members     #128   +/-   ##
==========================================
  Coverage      99.83%   99.83%           
- Complexity      1091     1094    +3     
==========================================
  Files            190      190           
  Lines           3108     3116    +8     
==========================================
+ Hits            3103     3111    +8     
  Misses             5        5           
Impacted Files Coverage Δ Complexity Δ
src/Controller/OAuth/BitbucketController.php 100.00% <ø> (ø) 6.00 <0.00> (ø)
src/Controller/OAuth/GitHubController.php 100.00% <ø> (ø) 6.00 <0.00> (ø)
src/Controller/OAuth/GitLabController.php 100.00% <ø> (ø) 6.00 <0.00> (ø)
src/Controller/Organization/PackageController.php 100.00% <ø> (ø) 41.00 <0.00> (ø)
src/Controller/OrganizationController.php 100.00% <ø> (ø) 35.00 <0.00> (ø)
src/Entity/Organization/Member.php 100.00% <ø> (ø) 8.00 <0.00> (ø)
src/Controller/Organization/MembersController.php 100.00% <100.00%> (ø) 10.00 <2.00> (ø)
src/Service/Organization/OrganizationVoter.php 100.00% <100.00%> (ø) 8.00 <0.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bca561f...2406b7a. Read the comment docs.

@karniv00l karniv00l merged commit 673037d into repman-io:members Apr 29, 2020
@akondas akondas deleted the members-permissions branch April 29, 2020 20:58
karniv00l pushed a commit that referenced this pull request May 4, 2020
* Allow to manage organization members in UI (#118)

* Create owner role and prepare migration (#127)

* Implement members permissions (#128)

* Fix doctrine proxy and UI for organization members (#130)
@akondas akondas mentioned this pull request Sep 11, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants