Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to manage organization members in UI #118

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

akondas
Copy link
Member

@akondas akondas commented Apr 27, 2020

No description provided.

@akondas akondas requested a review from karniv00l April 27, 2020 17:53
</svg>
<span class="d-none d-sm-block">Members</span>
</a>
</li>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2020-04-27 19-53-32

@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #118 into members will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             members     #118      +/-   ##
=============================================
+ Coverage      99.62%   99.83%   +0.21%     
- Complexity      1027     1073      +46     
=============================================
  Files            182      190       +8     
  Lines           2939     3083     +144     
=============================================
+ Hits            2928     3078     +150     
+ Misses            11        5       -6     
Impacted Files Coverage Δ Complexity Δ
src/Form/Type/User/RegisterType.php 100.00% <ø> (ø) 2.00 <0.00> (ø)
...c/Message/Organization/Member/AcceptInvitation.php 100.00% <ø> (ø) 3.00 <0.00> (?)
src/Message/Organization/Member/InviteUser.php 100.00% <ø> (ø) 5.00 <0.00> (?)
...er/Organization/Member/AcceptInvitationHandler.php 100.00% <ø> (ø) 2.00 <0.00> (?)
src/Controller/Organization/MembersController.php 100.00% <100.00%> (ø) 10.00 <10.00> (?)
src/Entity/Organization.php 100.00% <100.00%> (ø) 30.00 <5.00> (+3.00)
src/Entity/Organization/Member.php 100.00% <100.00%> (ø) 5.00 <1.00> (+1.00)
src/Form/Type/Organization/InviteMemberType.php 100.00% <100.00%> (ø) 3.00 <3.00> (?)
...c/Message/Organization/Member/RemoveInvitation.php 100.00% <100.00%> (ø) 3.00 <3.00> (?)
src/Message/Organization/Member/RemoveMember.php 100.00% <100.00%> (ø) 3.00 <3.00> (?)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ab649f...659feb4. Read the comment docs.

</table>
{% include 'component/pagination.html.twig' with {'path_name': 'organization_invitations', 'path_params': {'organization': organization.alias}} %}
</div>
{% endblock %}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2020-04-27 19-54-38

@karniv00l karniv00l merged commit 14a0e35 into repman-io:members Apr 27, 2020
karniv00l pushed a commit that referenced this pull request May 4, 2020
* Allow to manage organization members in UI (#118)

* Create owner role and prepare migration (#127)

* Implement members permissions (#128)

* Fix doctrine proxy and UI for organization members (#130)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants