Create owner role and prepare migration #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akondas
commented
Apr 29, 2020
| @@ -129,6 +129,7 @@ | |||
| "@phpstan", | |||
| "@coverage-ci", | |||
| "bin/console lint:twig templates --show-deprecations", | |||
| "rm -rf var/cache/prod", | |||
There was a problem hiding this comment.
prevent fail when entity mapping changed
Codecov Report
@@ Coverage Diff @@
## members #127 +/- ##
==========================================
Coverage 99.83% 99.83%
- Complexity 1073 1087 +14
==========================================
Files 190 190
Lines 3083 3102 +19
==========================================
+ Hits 3078 3097 +19
Misses 5 5
Continue to review full report at Codecov.
|
akondas
commented
Apr 29, 2020
| $this->addSql('ALTER TABLE organization_package ADD CONSTRAINT FK_13BAEFD632C8A3DE FOREIGN KEY (organization_id) REFERENCES organization (id) NOT DEFERRABLE INITIALLY IMMEDIATE'); | ||
| $this->addSql('ALTER TABLE organization_token ADD CONSTRAINT FK_D1B047FC32C8A3DE FOREIGN KEY (organization_id) REFERENCES organization (id) NOT DEFERRABLE INITIALLY IMMEDIATE'); | ||
| $this->addSql('ALTER TABLE organization ADD CONSTRAINT FK_C1EE637C7E3C61F9 FOREIGN KEY (owner_id) REFERENCES "user" (id) NOT DEFERRABLE INITIALLY IMMEDIATE'); | ||
| $this->addSql('ALTER TABLE user_oauth_token ADD CONSTRAINT FK_712F82BFA76ED395 FOREIGN KEY (user_id) REFERENCES "user" (id) NOT DEFERRABLE INITIALLY IMMEDIATE'); |
There was a problem hiding this comment.
shame 😞 it had to be lost when flattening migration
akondas
commented
Apr 29, 2020
| @@ -36,11 +34,6 @@ public function alias(): string | |||
| return $this->alias; | |||
| } | |||
|
|
|||
| public function ownerEmail(): string | |||
| { | |||
| return $this->ownerEmail; | |||
There was a problem hiding this comment.
for now removed, maybe we will need members feature for admin (but for now it's not needed)
akondas
commented
Apr 29, 2020
tests/Unit/Entity/UserTest.php
Outdated
| public function testNoneWhenNoOrganizations(): void | ||
| { | ||
| self::assertTrue(Option::none()->equals($this->user->firstOrganizationAlias())); | ||
| } |
There was a problem hiding this comment.
hmm, this should not be removed
akondas
force-pushed
the
members-migration
branch
from
25cc19c to
764b5a0
Compare
akondas
force-pushed
the
members-migration
branch
from
764b5a0 to
c24e449
Compare
karniv00l
approved these changes
Apr 29, 2020
akondas
added a commit
that referenced
this pull request
Apr 29, 2020
karniv00l
pushed a commit
that referenced
this pull request
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next part of #56.
⚠️
Now everyone can do anything 😱 , so I have to create permissions.