-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager/gradle): add support for Groovy and Kotlin maps #19127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Nov 27, 2022
zharinov
reviewed
Nov 28, 2022
zharinov
previously approved these changes
Nov 28, 2022
Co-authored-by: Sergei Zharinov <zharinov@users.noreply.github.com>
viceice
reviewed
Nov 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
zharinov
previously approved these changes
Nov 28, 2022
viceice
reviewed
Nov 28, 2022
viceice
approved these changes
Nov 28, 2022
🎉 This PR is included in version 34.41.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds support for map collections up to 3rd-level nesting.
Support for Groovy maps, e.g.
Support for Kotlin's
mapOf
collections, e.g.Implementation Notes
deps
->deps.support
->deps.support.junit
. The limitation of max. three levels was deliberately chosen to keep the code neat (while being still real-world friendly) but could be expanded, if needed.handler.ts
were made to match situations, where the map entry contains a string value that requires interpolation, e.g.kotlinPlugin
is not added as a variable then as this would result in indirect variable references (varA: "someother$varB"
). This is just an explanation, no limitation - this is the same behavior for simple, single variables already as well.Context
Real-world examples that previously (= until this PR) didn't match at all:
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via:
Test repository (= minimal reproduction from #13619):
Logs