Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(manager/gradle): group parser directives in separate files #19465

Merged
merged 1 commit into from
Dec 18, 2022

Conversation

Churro
Copy link
Collaborator

@Churro Churro commented Dec 17, 2022

Changes

  • parser.ts: split the functionality into dedicated files (pure copy-paste without functional changes) for better maintainability. Where meaningful, directives were exported, summarized as qDependencies or qAssignments to abstract away individual Groovy and Kotlin constructs from parser.ts.
  • handler.ts: Apply a previous refactoring suggestion regarding ctx.globalVars to all occurrences

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@Churro Churro marked this pull request as draft December 17, 2022 21:06
@Churro Churro marked this pull request as ready for review December 17, 2022 21:06
@rarkins rarkins merged commit 6beeba6 into renovatebot:main Dec 18, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.63.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants