Spotbugs library and plugin versions mixed up #13619
Comments
KayBestmann1123
added
priority-5-triage
status:requirements
|
Does the problem go away if you use different variable names? |
|
Please see the comment https://github.com/KayBestmann1123/renovatetest/commit/1b40984c79569eec454e9d88747dfa102e836db1#r64093727 Changed the variable name: Did not help. |
|
Reproduction forked to https://github.com/renovate-reproductions/13619 |
rarkins
added
reproduction:provided
priority-3-medium
|
Hey any update here? I'm facing same issue. |
|
@rarkins I've tried to reproduce using the forked test data and received a suggested update to @pujanshah3333 Did you try on a different repo or config? |
rarkins
added
auto:reproduction
|
Hi there, Help us by making a minimal reproduction repository. Before we can start work on your issue we first need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. To get started, please read our guide on creating a minimal reproduction to understand what is needed. We may close the issue if you (or someone else) have not provided a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment. Good luck, The Renovate team |
|
@hasanwhitesource is it possible that you've linked the wrong url? Because i can see neither a PR nor any by renovate created branch. In addition the same mix up is still happening in the given test repository, as well as in multiple repositories on my end. |
Where do you see that?
I have tried with same config. |
|
You can see v5.0.5 in the body of the linked onboarding PR |
I guess you are referring to
We are getting similar from Renovate in our repositories: But when it's actually creating the commit, it looks like: |
|
Let's wait on a minimal reproduction then. |
|
When a bug has been marked as needing a reproduction, it means nobody can work on it until one is provided. In cases where no reproduction is possible, or the issue creator does not have the time to reproduce, we unfortunately need to close such issues as they are non-actionable and serve no benefit by remaining open. This issue will be closed after 7 days of inactivity. |
|
@rarkins : I've updated the linked repository to create a PR to better highlight the issue and removed everything non-issue related so it's actually a minimal reproduction. See the PR with the suggested correct change (Identical to @hasanwhitesource test PR 22 days ago): See the actual created commit (or files changed) inside the repository with the incorrect change: -> |
hasanwhitesource
added
reproduction:provided
and removed
auto:reproduction
|
I have forked your test repo and added this config and received the expected update. Would you kindly verify and run on the latest renovate version and also check if my config satisfies your needs? |
|
@hasanwhitesource Do you know why it hasn't picked up spotbugs_annotations upgrade from 4.5.2 to 4.5.3 in your test repo? |
|
Unfortunately, we need to add support for this variable definition syntax |
|
Btw, I'm working on parsing library which would help to handle Gradle syntax variations: https://github.com/zharinov/good-enough-parser/ I had plans to port current Gradle implementation to use this library (actually, it was inspired by Gradle implementation) |
nabeelsaabna
removed
the
status:requirements
Reading your last comments back then, @hasanwhitesource and @zharinov, I was confused as apparently Renovate worked within our setup with the versions of our dependencies specified in a separated file. We just recently noticed, Renovate is no longer picking up newer versions for our Java dependencies since quite some time. I figured that it's related to #13490, deprecation and eventually removal of deepExtract with Renovate 32. Can you confirm that removing functionality behind deepExtract config parameter made it working until Renovate 31 - and only now Renovate has the limitation with the separate file as stated? Are you aware of any background for removing deepExtract (discussions, reasoning for product decisions, or alike) or alternatives? |
|
We no longer run binaries as part of the extract process. DeepExtract required running gradle itself. |
|
@rarkins Is there some background information available on removing deepExtract feature? In the linked #13490 they are quoting you but I don't know from where. |
|
search issues and discussions for we removed all manager code which depends on external tool for extraction because of too many errors / bugs and performance problems. we issued deprecation warnings a long time before about that. so it will never come back. |
How are you running Renovate?
Self-hosted
If you're self-hosting Renovate, tell us what version of Renovate you run.
latest (31.28.5)
Please select which platform you are using if self-hosting.
github.com
If you're self-hosting Renovate, tell us what version of the platform you run.
No response
Describe the bug
Renovate tries to apply version of spotbugs_annotations java library to spotbugs gradle plugin. This results in a downgrade for spotbugs gradle plugins.
See for reference:
https://github.com/KayBestmann1123/renovatetest/commit/1b40984c79569eec454e9d88747dfa102e836db1
Relevant debug logs
Logs
The text was updated successfully, but these errors were encountered: