-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Datasource classes #8647
Comments
My initial attempt at converting |
@JamieMagee I understand that PR better now. Perhaps worth refreshing and merging after @viceice refactors our modules to statically load instead of dynamic? |
Are we really done here? |
There's some cleanup to do, but the majority of the work is now done. |
🎉 This issue has been resolved in version 31.82.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
I would like to consider class-based datasources to achieve better DRY than today plus some enhance features.
Currently datasources are somewhat declaration-based and the datasource index then handles things, e.g.
caching
, default registryUrls, etc. This type of stuff should remain although maybe much of the datasource index's logic will move into the base datasource class.We definitely want error handling shared as much as possible.
Caching would be another aspect done automatically.
Something new: our http layer returns an
auth
variable today to indicate that the request was auth'd. In future I think we may return an auth fingerprint (e.g. sha256 the authorization header content and then use the first 5 chars). This would then be used in conjunction with caching, to allow private lookup caching.Need to discuss how to do this. Start small and then enhance it?
The text was updated successfully, but these errors were encountered: