-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: static modules #8679
feat: static modules #8679
Conversation
Is generate-imports required anymore? |
Yes, for node schedule and pip_setup extractor. Maybe it should be renamed. 😏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a test for each of these modules to make sure that all (relevant) subdirectories are imported and match the import name.
Strange, not sure why it fails with oom. 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, leaving a comment from the GitHub app starts a full review.
EDIT: I left this comment earlier but had to 'approve' it on web. I have no idea what's going on here.
Yes, happens to me often. It defaults to pending comments in a review, not sure if you can change that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs 2 missing managers added :)
renovate/lib/datasource/index.spec.ts Line 49 in 21ebb74
renovate/lib/manager/index.spec.ts Line 35 in 53ca913
renovate/lib/platform/index.spec.ts Line 29 in 04d2cd1
renovate/lib/versioning/index.spec.ts Line 38 in 53ce3cf
Already tested 🙃 |
🎉 This PR is included in version 24.71.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
Convert generated to static modules
Context:
#8647 #6747
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: