Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(hex): convert to class-based #10642

Merged
merged 1 commit into from
Jun 29, 2021
Merged

refactor(hex): convert to class-based #10642

merged 1 commit into from
Jun 29, 2021

Conversation

JamieMagee
Copy link
Contributor

Changes:

Convert the hex datasource to be class-based.

This PR also adds caching for hex and I have some questions:

  • Is this datasource safe to cache?
    • My research says yes, but I'd rather check with someone who knows more
  • How long should it be cached for?
    • The default 30 minutes appears to be okay
  • Is lookupName a sufficient key?
    • hex doesn't support custom registries, and there is only 1 default registry, so lookupName on its own should be enough

Context:

Part of #8647

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@JamieMagee JamieMagee force-pushed the refactor/hex-datasource branch from e8cce39 to e1759f6 Compare June 29, 2021 01:35
@viceice viceice requested a review from rarkins June 29, 2021 05:55
@rarkins rarkins merged commit 1eebe56 into main Jun 29, 2021
@rarkins rarkins deleted the refactor/hex-datasource branch June 29, 2021 06:03
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.51.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants