Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(packagist): convert to class-based datasource #12227

Merged
merged 4 commits into from
Feb 11, 2022
Merged

refactor(packagist): convert to class-based datasource #12227

merged 4 commits into from
Feb 11, 2022

Conversation

JamieMagee
Copy link
Contributor

@JamieMagee JamieMagee commented Oct 20, 2021 •
edited
Loading

Changes:

Converts packagist datasource to be class-based

TODO:

  • Figure out mocking in lib/datasource/index.spec.ts

Context:

#8647

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@JamieMagee JamieMagee force-pushed the refactor/packagist-datasource branch from 6b1a3bc to 0a4965e Compare December 7, 2021 06:18
@rarkins
Copy link
Collaborator

rarkins commented Jan 16, 2022

Needs de-conflicting

@JamieMagee JamieMagee force-pushed the refactor/packagist-datasource branch 2 times, most recently from b269833 to 132c8f6 Compare January 20, 2022 06:06
@JamieMagee
Copy link
Contributor Author

I figured out how to mock correctly. Just a couple of tests to fix now.

@JamieMagee JamieMagee force-pushed the refactor/packagist-datasource branch from 30d77b3 to 9b96dd7 Compare January 25, 2022 06:17
@JamieMagee JamieMagee marked this pull request as ready for review January 25, 2022 06:17
@JamieMagee
Copy link
Contributor Author

I still have a little cleanup to do to the mocking in datasource/index.spec.ts, but it works.

@JamieMagee JamieMagee force-pushed the refactor/packagist-datasource branch from c07ca38 to 235678b Compare February 6, 2022 23:08
zharinov
zharinov previously approved these changes Feb 7, 2022
View reviewed changes
@JamieMagee JamieMagee force-pushed the refactor/packagist-datasource branch from 235678b to 1f1c24f Compare February 7, 2022 04:43
viceice
viceice reviewed Feb 8, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please try to not change the function order, so i can compare without whitespace to have less changes?

lib/datasource/index.spec.ts Outdated Show resolved Hide resolved
lib/datasource/packagist/index.ts Outdated Show resolved Hide resolved
@viceice
Copy link
Member

viceice commented Feb 9, 2022

This will collide with

@JamieMagee JamieMagee force-pushed the refactor/packagist-datasource branch from 40fced9 to b0bc388 Compare February 11, 2022 05:45
JamieMagee and others added 3 commits February 10, 2022 21:45
@JamieMagee
refactor(packagist): convert to class-based datasource
2f3d902 
Correctly mock PackagistDatasource
@JamieMagee @viceice
Update lib/datasource/packagist/index.ts
c469043 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@JamieMagee
PR comments
5561e67
@JamieMagee JamieMagee force-pushed the refactor/packagist-datasource branch from b0bc388 to 5561e67 Compare February 11, 2022 05:45
@JamieMagee JamieMagee mentioned this pull request Feb 11, 2022
Merged
6 tasks
@JamieMagee JamieMagee requested a review from viceice February 11, 2022 05:47
viceice
viceice previously approved these changes Feb 11, 2022
View reviewed changes
@viceice viceice enabled auto-merge (squash) February 11, 2022 07:15
@viceice viceice merged commit 0a4b103 into main Feb 11, 2022
@viceice viceice deleted the refactor/packagist-datasource branch February 11, 2022 07:29
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 31.78.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@zharinov zharinov zharinov left review comments

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JamieMagee @rarkins @viceice @renovate-release @zharinov