-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test on windows #2562
Unit test on windows #2562
Changes from all commits
32f356d
9a7e775
d1551f0
942e3c6
f85acd5
4421a1e
48c8cea
10f59ef
b2331e8
94784cf
0d2fc25
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
// +build !windows,!osx | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Skipping watch test build on windows and macOS. It will be revised in #2570 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
It would be good to add this as a comment to all skipped files. |
||
|
||
package component | ||
|
||
import ( | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,18 @@ | ||
// +build !windows | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
package ui | ||
|
||
import ( | ||
"reflect" | ||
"testing" | ||
|
||
"github.com/Netflix/go-expect" | ||
beta1 "github.com/kubernetes-incubator/service-catalog/pkg/apis/servicecatalog/v1beta1" | ||
"github.com/openshift/odo/pkg/service" | ||
"github.com/openshift/odo/pkg/testingutil" | ||
"github.com/stretchr/testify/require" | ||
"gopkg.in/AlecAivazis/survey.v1/core" | ||
"gopkg.in/AlecAivazis/survey.v1/terminal" | ||
"reflect" | ||
"testing" | ||
) | ||
|
||
func init() { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,16 @@ | ||
// +build !windows | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Skipping build. Refer : #2630 for more details and same issue will be tracked in the mentioned link. |
||
|
||
package testingutil | ||
|
||
import ( | ||
"bytes" | ||
"testing" | ||
|
||
"github.com/Netflix/go-expect" | ||
"github.com/hinshun/vt10x" | ||
"github.com/stretchr/testify/require" | ||
"gopkg.in/AlecAivazis/survey.v1" | ||
"gopkg.in/AlecAivazis/survey.v1/terminal" | ||
"testing" | ||
) | ||
|
||
// This whole file copies the testing infrastructure from survey lib since it cannot be imported. This mixes elements from: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no
/tmp
on windows. How is this working? Is there some kind of conversion to windows paths?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kadel In travis minimal gnu for windows is set as a default terminal for running scripts. minimal gnu provides the similar Linux file system on windows platform. As per the gnu environment the temp file will be generated in
/tmp
directory. For exampleSo its good practice to remove the temp files before running the actual test.