Unit test on windows #2562

prietyc123 · 2020-02-04T07:38:20Z

What type of PR is this?

/kind feature

What does does this PR do / why we need it:

Run all the unit test on windows platform

Which issue(s) this PR fixes:

Fixes #2539

How to test changes / Special notes to the reviewer:
Unit test should run on windows through travis CI

kanchwala-yusuf · 2020-02-04T07:47:02Z

@prietyc123, @amitkrout:
Have you tried running these tests locally? maybe on a windows vm? Also, would the current CI pipeline execute unit tests on windows platform?

codecov · 2020-02-05T07:53:57Z

Codecov Report

❗ No coverage uploaded for pull request base (master@2cc1380). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #2562   +/-   ##
=========================================
  Coverage          ?   43.64%           
=========================================
  Files             ?       82           
  Lines             ?     7511           
  Branches          ?        0           
=========================================
  Hits              ?     3278           
  Misses            ?     3912           
  Partials          ?      321

Impacted Files	Coverage Δ
pkg/testingutil/survey_ui.go	`0% <ø> (ø)`
pkg/occlient/occlient.go	`52.73% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cc1380...0d2fc25. Read the comment docs.

kanchwala-yusuf · 2020-02-05T16:07:02Z

@prietyc123 , it seems that the make command is not installed on the Travis CI machine on which the unit tests are executed. You may need to change the job config to get it installed.

prietyc123 · 2020-02-06T11:09:42Z

/retest

amitkrout · 2020-02-06T11:27:21Z

/retest

prietyc123 · 2020-02-10T10:15:19Z

$ make test
go test -race github.com/openshift/odo/cmd/cli-doc github.com/openshift/odo/cmd/odo github.com/openshift/odo/pkg/application github.com/openshift/odo/pkg/application/labels github.com/openshift/odo/pkg/auth github.com/openshift/odo/pkg/catalog github.com/openshift/odo/pkg/component github.com/openshift/odo/pkg/component/labels github.com/openshift/odo/pkg/config github.com/openshift/odo/pkg/debug github.com/openshift/odo/pkg/devfile github.com/openshift/odo/pkg/devfile/parser 
[. . .]
FAIL	github.com/openshift/odo/pkg/application [build failed]
ok  	github.com/openshift/odo/pkg/application/labels	1.057s
?   	github.com/openshift/odo/pkg/auth	[no test files]
FAIL	github.com/openshift/odo/pkg/catalog [build failed]
FAIL	github.com/openshift/odo/pkg/component [build failed]
ok  	github.com/openshift/odo/pkg/component/labels	1.039s
ok  	github.com/openshift/odo/pkg/config	1.343s
?   	github.com/openshift/odo/pkg/debug	[no test files]
ok  	github.com/openshift/odo/pkg/devfile	1.111s
ok  	github.com/openshift/odo/pkg/devfile/parser	1.136s
ok  	github.com/openshift/odo/pkg/devfile/versions	1.066s
?   	github.com/openshift/odo/pkg/devfile/versions/1.0.0	[no test files]
ok  	github.com/openshift/odo/pkg/devfile/versions/common	1.146s
ok  	github.com/openshift/odo/pkg/kclient	1.201s
?   	github.com/openshift/odo/pkg/log	[no test files]
?   	github.com/openshift/odo/pkg/log/fidget	[no test files]
?   	github.com/openshift/odo/pkg/machineoutput	[no test files]
ok  	github.com/openshift/odo/pkg/notify	1.065s [no tests to run]
FAIL	github.com/openshift/odo/pkg/occlient [build failed]
[. . .]

Few unit tests build is failed. So it is blocked till #2586 issue is fixed.

mik-dass · 2020-02-14T10:19:02Z

Netflix/go-expect#10 according to the issue, the go-expect library is not supported on windows. We are using the library here https://github.com/openshift/odo/blob/bba04d2aeb8a4f02867b320d93554c70e7726072/glide.yaml#L46 in ODO. This is the reason build is failing on windows

PS C:\Users\Admin\go\src\github.com\openshift\odo> go test -count=1 pkg/project/project.go pkg/project/project_test.go pkg/project/types.go
# github.com/openshift/odo/vendor/github.com/kr/pty
vendor\github.com\kr\pty\shim.go:26:16: undefined: pty.Winsize
vendor\github.com\kr\pty\shim.go:32:63: undefined: pty.Getsize
vendor\github.com\kr\pty\shim.go:38:9: undefined: pty.GetsizeFull
vendor\github.com\kr\pty\shim.go:47:52: undefined: pty.InheritSize
vendor\github.com\kr\pty\shim.go:57:54: undefined: pty.Setsize
vendor\github.com\kr\pty\shim.go:64:60: undefined: pty.Start
vendor\github.com\kr\pty\shim.go:75:9: undefined: pty.StartWithSize
FAIL    command-line-arguments [build failed]
FAIL

Also tektoncd/cli#191 might help you find a solution.

amitkrout · 2020-02-16T10:05:53Z

Netflix/go-expect#10 according to the issue, the go-expect library is not supported on windows. We are using the library here

https://github.com/openshift/odo/blob/bba04d2aeb8a4f02867b320d93554c70e7726072/glide.yaml#L46

in ODO. This is the reason build is failing on windows
PS C:\Users\Admin\go\src\github.com\openshift\odo> go test -count=1 pkg/project/project.go pkg/project/project_test.go pkg/project/types.go
# github.com/openshift/odo/vendor/github.com/kr/pty
vendor\github.com\kr\pty\shim.go:26:16: undefined: pty.Winsize
vendor\github.com\kr\pty\shim.go:32:63: undefined: pty.Getsize
vendor\github.com\kr\pty\shim.go:38:9: undefined: pty.GetsizeFull
vendor\github.com\kr\pty\shim.go:47:52: undefined: pty.InheritSize
vendor\github.com\kr\pty\shim.go:57:54: undefined: pty.Setsize
vendor\github.com\kr\pty\shim.go:64:60: undefined: pty.Start
vendor\github.com\kr\pty\shim.go:75:9: undefined: pty.StartWithSize
FAIL    command-line-arguments [build failed]
FAIL
Also tektoncd/cli#191 might help you find a solution.

Issue created - #2586 to track UTs failure travis CI on Win10 platform cc_ @prietyc123

prietyc123 · 2020-03-06T09:41:16Z

pkg/component/watch_test.go

@@ -1,3 +1,6 @@
+// +build !windows


Skip build for windows and macOS. Watch test will be revised in #2570 for windows and macOS.

prietyc123 · 2020-03-06T09:41:28Z

pkg/component/watch_test.go

@@ -1,3 +1,6 @@
+// +build !windows
+// +build !osx


https://github.com/openshift/odo/pull/2562/files#r388802204

@prietyc123 Can we make this in a single line ? For example

// +build !windows !osx

@prietyc123 Can we make this in a single line ? For example

// +build !windows !osx

Done with // +build !windows,!osx

prietyc123 · 2020-03-06T10:06:09Z

https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_odo/2562/pull-ci-openshift-odo-master-v4.3-integration-e2e-benchmark/1061#1:build-log.txt%3A33

/retest

prietyc123 · 2020-03-06T10:30:18Z

/retest

prietyc123 · 2020-03-06T14:04:59Z

/test v4.3-integration-e2e-benchmark

prietyc123 · 2020-03-08T08:30:37Z

pkg/component/watch_test.go

@@ -1,3 +1,5 @@
+// +build !windows,!osx


Skipping watch test build on windows and macOS. It will be revised in #2570

Skipping watch test build on windows and macOS. It will be revised in #2570

It would be good to add this as a comment to all skipped files.

amitkrout · 2020-03-09T13:43:17Z

/lgtm

kadel · 2020-03-10T09:05:32Z

.travis.yml

+      script:
+        - export PATH="$PATH:$GOPATH/bin"
+        - make bin
+        - rm -r /tmp/*


There is no /tmp on windows. How is this working? Is there some kind of conversion to windows paths?

@kadel In travis minimal gnu for windows is set as a default terminal for running scripts. minimal gnu provides the similar Linux file system on windows platform. As per the gnu environment the temp file will be generated in /tmp directory. For example

So its good practice to remove the temp files before running the actual test.

cdrage

Tests LGTM!

/approve

openshift-ci-robot · 2020-03-10T14:52:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [cdrage]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation size/S labels Feb 4, 2020

prietyc123 changed the title ~~Unit test on windows~~ [WIP]Unit test on windows Feb 4, 2020

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Feb 4, 2020

openshift-ci-robot requested review from cdrage and kanchwala-yusuf February 4, 2020 07:39

prietyc123 force-pushed the RunUnitTestOnWindows branch from 8d59973 to b8eb7f1 Compare February 5, 2020 07:53

prietyc123 force-pushed the RunUnitTestOnWindows branch 5 times, most recently from 32c7bee to 4193876 Compare February 6, 2020 10:55

openshift-ci-robot added size/M and removed size/S labels Feb 7, 2020

prietyc123 force-pushed the RunUnitTestOnWindows branch 3 times, most recently from e0cf020 to c8d0d73 Compare February 12, 2020 10:35

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Feb 13, 2020

prietyc123 force-pushed the RunUnitTestOnWindows branch from 3a9c518 to f49c2e2 Compare February 14, 2020 10:26

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Feb 14, 2020

amitkrout mentioned this pull request Feb 16, 2020

Package github.com/Netflix/go-expect affecting some unit tests on Windows #2586

Closed

prietyc123 force-pushed the RunUnitTestOnWindows branch from f49c2e2 to e69d430 Compare February 19, 2020 12:00

prietyc123 added 8 commits March 6, 2020 14:56

fixing make error for running unit test on windows

9a7e775

Changed unit test for windows platform in util_test.go

d1551f0

makefile vorvose mode to check the detailed error

942e3c6

Skipping github.com/Netflix/go-expect on windows

f85acd5

Fixing server start error on windows

4421a1e

Checking more specific watch.go error

48c8cea

Fix debug error due to full tmp file

10f59ef

Skip watch_test.go build on windows and macOS

b2331e8

prietyc123 force-pushed the RunUnitTestOnWindows branch from c066906 to b2331e8 Compare March 6, 2020 09:31

prietyc123 changed the title ~~[WIP]Unit test on windows~~ Unit test on windows Mar 6, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Mar 6, 2020

Excluded Printing error for more details on watch

94784cf

prietyc123 commented Mar 6, 2020

View reviewed changes

Skipped build in a single line

0d2fc25

prietyc123 commented Mar 8, 2020

View reviewed changes

openshift-ci-robot assigned amitkrout Mar 9, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 9, 2020

mik-dass mentioned this pull request Mar 10, 2020

Fixes watch unit tests for windows #2692

Merged

kadel reviewed Mar 10, 2020

View reviewed changes

cdrage approved these changes Mar 10, 2020

View reviewed changes

openshift-ci-robot assigned cdrage Mar 10, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Mar 10, 2020

openshift-merge-robot merged commit 8c05b3d into redhat-developer:master Mar 10, 2020

rm3l added the estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person label Jun 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unit test on windows #2562

Unit test on windows #2562

prietyc123 commented Feb 4, 2020 •

edited

Loading

kanchwala-yusuf commented Feb 4, 2020

codecov bot commented Feb 5, 2020 •

edited

Loading

kanchwala-yusuf commented Feb 5, 2020

prietyc123 commented Feb 6, 2020

amitkrout commented Feb 6, 2020

prietyc123 commented Feb 10, 2020

mik-dass commented Feb 14, 2020 •

edited

Loading

amitkrout commented Feb 16, 2020

prietyc123 Mar 6, 2020

prietyc123 Mar 6, 2020

amitkrout Mar 6, 2020

prietyc123 Mar 6, 2020 •

edited

Loading

prietyc123 commented Mar 6, 2020

prietyc123 commented Mar 6, 2020

prietyc123 commented Mar 6, 2020

prietyc123 Mar 8, 2020

kadel Mar 10, 2020

amitkrout commented Mar 9, 2020

kadel Mar 10, 2020

amitkrout Mar 10, 2020

cdrage left a comment

openshift-ci-robot commented Mar 10, 2020

Unit test on windows #2562

Unit test on windows #2562

Conversation

prietyc123 commented Feb 4, 2020 • edited Loading

kanchwala-yusuf commented Feb 4, 2020

codecov bot commented Feb 5, 2020 • edited Loading

Codecov Report

kanchwala-yusuf commented Feb 5, 2020

prietyc123 commented Feb 6, 2020

amitkrout commented Feb 6, 2020

prietyc123 commented Feb 10, 2020

mik-dass commented Feb 14, 2020 • edited Loading

amitkrout commented Feb 16, 2020

prietyc123 Mar 6, 2020

Choose a reason for hiding this comment

prietyc123 Mar 6, 2020

Choose a reason for hiding this comment

amitkrout Mar 6, 2020

Choose a reason for hiding this comment

prietyc123 Mar 6, 2020 • edited Loading

Choose a reason for hiding this comment

prietyc123 commented Mar 6, 2020

prietyc123 commented Mar 6, 2020

prietyc123 commented Mar 6, 2020

prietyc123 Mar 8, 2020

Choose a reason for hiding this comment

kadel Mar 10, 2020

Choose a reason for hiding this comment

amitkrout commented Mar 9, 2020

kadel Mar 10, 2020

Choose a reason for hiding this comment

amitkrout Mar 10, 2020

Choose a reason for hiding this comment

cdrage left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Mar 10, 2020

prietyc123 commented Feb 4, 2020 •

edited

Loading

codecov bot commented Feb 5, 2020 •

edited

Loading

mik-dass commented Feb 14, 2020 •

edited

Loading

prietyc123 Mar 6, 2020 •

edited

Loading