-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLAKE]make test fails on osx and windows in travis CI #2570
Comments
@mik-dass Based on your comment #2571 (comment) on the duplicate issue #2571, do we really need this issue ? cc_ @prietyc123 |
Yes this is a different issue than that. This was introduced in #2549 (comment). This was the reason we bumped the go version on the travis CI. |
/area testing |
/priority high |
Skipped watch test on windows and macOS in https://github.com/openshift/odo/pull/2562/files#r389347456. @girishramnani |
#2692 only solved the flake for windows. |
@mik-dass it seems the flake on mac (travis CI) appears more frequently, even i can now reproduce it locally on my mac setup. occurrence - https://travis-ci.com/github/openshift/odo/jobs/307573205#L210 |
No
Since this test passes on Linux and windows, let's keep the issue open and skip it for mac OS for now. WDYT? |
Let's try to fix it. I don't think that skipping tests is a good idea. |
On linux
Increasing the parallel nodes on the watch test to 5 seems to result in 3 |
@mik-dass We are hitting the same issue on windows https://travis-ci.com/github/openshift/odo/jobs/337120311#L233 |
It was thrown by the fsnotify library https://github.com/fsnotify/fsnotify/blob/master/windows.go#L506 due to some problem with the windows OS. |
Ok, then we should add patch in the upstream or let’s create an issue there to keep a track of that. Or is there any possibility to fix it from our end ? |
Hitting the same issue again - https://travis-ci.com/github/openshift/odo/jobs/337411640#L248 pr reference - #3218 |
The error is already handled upstream by throwing an error from their side. To fix this, we probably will need fix from windows side. The only other solution I can think of is ignoring this error in code. But that can lead to other problems. |
@mik-dass Skip is not a good idea as you mentioned. This issue has been hit twice, and i am sure more will come in recent future. AFAIK travis does not do image update, then how come suddenly our test fails. Or am i missing anything ? |
Yeah more will come and I am sure about that too.
Are you sure about that? |
yes, just for your reference i am attaching a screen shoot. Logs collected from the travis CI |
Ok let me check locally on a windows machine |
I have tested the latest master watch test code 100+ times on a windows machine but couldn't reproduce the issue a single time. Also I think we should close this issue and create a new one as, log wise, most probably it has nothing to do with the issue reported. |
Ok, make sense. @prietyc123 Please go ahead and open an issue with the fresh logs. |
Yes, I have raised a new issue |
/kind bug
/kind flake
What versions of software are you using?
Operating System:
Output of
odo version
: masterHow did you run odo exactly?
On OpenShift CI
Actual behavior
Failed in getting the details of the changed file
TestWatchAndPush
on macOS.Also watch.go is creating some temporary files
C:\Users\travis\AppData\Local\Temp\fabric8-analytics-license-analysis047095974\tests417416904\test_read_licenses.py216365071
which is failed to get detected on windows.Expected behavior
make test
should passAny logs, error output, etc?
macOS travis CI
windows travis CI
Issue ref : https://travis-ci.com/openshift/odo/jobs/281881842#L133 and https://travis-ci.com/openshift/odo/jobs/293340097#L110
The text was updated successfully, but these errors were encountered: