Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit test fails on macOS #2571

Closed
amitkrout opened this issue Feb 6, 2020 · 6 comments
Closed

unit test fails on macOS #2571

amitkrout opened this issue Feb 6, 2020 · 6 comments

Comments

@amitkrout
Copy link
Contributor

/kind bug

What versions of software are you using?

Operating System:
macOS
Output of odo version:
master

How did you run odo exactly?

make test

Actual behavior

$ make test

go test -race github.com/openshift/odo/cmd/cli-doc github.com/openshift/odo/cmd/odo github.com/openshift/odo/pkg/application github.com/openshift/odo/pkg/application/labels github.com/openshift/odo/pkg/auth github.com/openshift/odo/pkg/catalog github.com/openshift/odo/pkg/component github.com/openshift/odo/pkg/component/labels 
[...]
?   	github.com/openshift/odo/cmd/cli-doc	[no test files]
?   	github.com/openshift/odo/cmd/odo	[no test files]
ok  	github.com/openshift/odo/pkg/application	1.305s
ok  	github.com/openshift/odo/pkg/application/labels	1.027s
?   	github.com/openshift/odo/pkg/auth	[no test files]
ok  	github.com/openshift/odo/pkg/catalog	1.184s
ok  	github.com/openshift/odo/pkg/component	12.678s
ok  	github.com/openshift/odo/pkg/component/labels	1.057s
ok  	github.com/openshift/odo/pkg/config	1.094s
--- FAIL: Test_getDebugInfo (0.02s)
    --- FAIL: Test_getDebugInfo/case_1:_the_debug_file_exists (0.01s)
        info_test.go:317: getDebugInfo() got = {{ } 0    0 0}, want {{OdoDebugInfo v1} 8078 testing-1 app nodejs-ex 5858 9001}
        info_test.go:320: getDebugInfo() got1 = false, want true
FAIL
FAIL	github.com/openshift/odo/pkg/debug	0.181s
ok  	github.com/openshift/odo/pkg/devfile	1.071s
ok  	github.com/openshift/odo/pkg/devfile/parser	1.112s
ok  	github.com/openshift/odo/pkg/devfile/versions	1.073s
?   	github.com/openshift/odo/pkg/devfile/versions/1.0.0	[no test files]
ok  	github.com/openshift/odo/pkg/devfile/versions/common	1.150s
ok  	github.com/openshift/odo/pkg/kclient	1.116s
[...]
FAIL
make: *** [test] Error 1
The command "make test" exited with 2.

## Expected behavior
UTs should be executed successfully

## Any logs, error output, etc?


@amitkrout amitkrout added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent labels Feb 6, 2020
@amitkrout
Copy link
Contributor Author

@mik-dass I am assigning this unit test failure to you because you have done the recent changes to the DebugInfo changes from where the error is coming.

Please consider this a s high priority as it blocks #2518

@amitkrout
Copy link
Contributor Author

@mik-dass you can handle this issue along with your pr #2518.

@mik-dass
Copy link
Contributor

mik-dass commented Feb 6, 2020

@mik-dass I am assigning this unit test failure to you because you have done the recent changes to the DebugInfo changes from where the error is coming.

My PR is not merged yet. This error occurred on my PR, I will fix it there. No need to create a issue yet.

@kadel
Copy link
Member

kadel commented Feb 6, 2020

@amitkrout critical priority is for thinks that break odo. Blocking PR from being merged is not critical.

/priority high
/remove-priority critical-urgent

@openshift-ci-robot
Copy link
Collaborator

@kadel: The label(s) priority/hight cannot be applied, because the repository doesn't have them

In response to this:

@amitkrout critical priority is for thinks that break odo. Blocking PR from being merged is not critical.

/priority hight
/remove-priority critical-urgent

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). label Feb 6, 2020
@openshift-ci-robot
Copy link
Collaborator

@kadel: Those labels are not set on the issue: priority/, priority/critical-urgent, priority/

In response to this:

@amitkrout critical priority is for thinks that break odo. Blocking PR from being merged is not critical.

/priority high
/remove-priority critical-urgent

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mik-dass mik-dass removed kind/bug Categorizes issue or PR as related to a bug. priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). labels Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants